hanakin wrote:callumacrae wrote:Oleg wrote:callumacrae wrote:What do you mean by the giant switch statement?
https://github.com/callumacrae/phpbb3/b ... le/ajax.js would be an example.
That's a horrible piece of code, but there is no way around it without rewriting the buttons / removing support for users with js disabled. I still don't understand what you mean by giant switch statement.
That could totaly be cleaned up, I agree with oleg take another look at this if i ever manage to get my computer back up and running I will attempt to provide some alternatives
It has already been cleaned up: https://github.com/igorw/phpbb3/blob/fe ... le/ajax.js