[RFC|Merged] Remove prosilver styleswitcher

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

[RFC|Merged] Remove prosilver styleswitcher

Post by igorw » Mon Jul 11, 2011 10:52 pm

The styleswitcher is, in my opinion, quite a useless invention. Adjusting font sizes can be done by the browser.

Removing the styleswitcher has been discussed several times before, in the prosilver modernisation and jquery topics, but also on IRC. It would make sense to discuss this issue separately and make it official.

I'd like to get rid of the styleswitcher.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-10260
Patch: https://github.com/phpbb/phpbb3/pull/271

If this gets accepted, I'll create a ticket and make a proper patch with properly formatted commit message. EDIT: done.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by naderman » Mon Jul 11, 2011 11:20 pm

Agree entirely.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by bantu » Mon Jul 11, 2011 11:26 pm

naderman wrote:Agree entirely.
+1


User avatar
Ger
Registered User
Posts: 270
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by Ger » Tue Jul 12, 2011 12:42 pm

Agree ++;
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by Vinny » Tue Jul 12, 2011 2:43 pm

Agree.
Good idea.

User avatar
Sierron
Registered User
Posts: 62
Joined: Wed Aug 25, 2010 11:41 am
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by Sierron » Thu Jul 14, 2011 2:42 pm

+1 from me too :)

I'm not sure if anyone even use it anyways. I know that some styles remove the that font resize button anyways.

User avatar
/a3
Registered User
Posts: 97
Joined: Mon Sep 20, 2010 6:44 am

Re: [RFC] Remove prosilver styleswitcher

Post by /a3 » Thu Jul 14, 2011 8:25 pm

igorw wrote:Adjusting font sizes can be done by the browser.
Will proSilver use relative font sizes instead of pixels by default? Currently, everything is relative to 10px, so the only way to "resize" fonts is through the styleswitcher or using zoom.
$ git commit -m "YOLO"

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by nickvergessen » Thu Jul 14, 2011 8:43 pm

/a3 wrote:Will proSilver use relative font sizes instead of pixels by default? Currently, everything is relative to 10px, so the only way to "resize" fonts is through the styleswitcher or using zoom.
The 10px is only for setting the default, so all browsers display the same size. Apart from that prosilver only uses relative.
Member of the Development-TeamNo Support via PM

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] Remove prosilver styleswitcher

Post by Vinny » Fri Jul 15, 2011 7:10 pm

I think that the image prosilver/theme/images/icon_fontsize.gif should also be removed, I looked at the patch and it wasn't removed.

Post Reply