[RFC|Merged] HTML5 doctype

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] HTML5 doctype

Post by naderman » Mon Sep 12, 2011 6:54 am

VSE+ wrote:However, the use of tables is pretty widespread in prosilver, especially in subsilver2 and also in the ACP. While class names already assigned to the tables, such as "table1" in the mcp pages, are common, the values of these formatting attributes tags can vary between all the different tables of class "table1"
Do they really? I would think that except for width they are probably all the same, in which case I'd add a class for each necessary width (kind of grid-system like).

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Mon Sep 12, 2011 7:03 am

These are some of the ones I found briefly:

<table class="table1" cellspacing="0">
<table class="table1" cellspacing="1">

<table class="tablebg" width="100%" cellspacing="1">
<table class="tablebg" width="100%" cellspacing="1" cellpadding="0" style="margin-top: 5px;">
<table class="tablebg" width="95%" cellspacing="1" cellpadding="4" border="0" align="center">
<table width="100%" class="tablebg" cellspacing="1" cellpadding="4" border="0">

There are tons more... It looks like a big task - especially in the subsilver2 area. :cry:
Has an irascible disposition.

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] HTML5 doctype

Post by Arty » Mon Sep 12, 2011 7:51 am

Code: Select all

table.tablebg { 
border-collapse: separate;
border-spacing: 1px; 
}
It should work in IE8+ and real browsers. I'm not sure how it will behave in IE7, my guess is border will be 2px instead of 1 because it doesn't support border-spacing, but it does support border-collapse.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Mon Sep 12, 2011 6:17 pm

So I found that...

In the ACP, virtually every TABLE tag has a cellspacing="1"
This can be handled in CSS with:

Code: Select all

border-spacing: 1px;
In prosilver, almost all TABLE tags have the class of "table1" with the only differences being cellspacings of either "1" or "0"
Most use cellspacing="1" so maybe make that the default for the table1 class, and add a new class for the 4 occurrences of cellspacing="0" ??

Code: Select all

table.table1 {border-spacing: 1px;}
table.table1 .nospacing {border-spacing: 0;}
The real behemoth is subsilver2, with over 250 TABLE tags, and a variety of differences between them.
Has an irascible disposition.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 doctype

Post by callumacrae » Mon Sep 12, 2011 6:35 pm

Don't bother with subsilver, I don't think it is XHTML valid anyway.
Made by developers, for developers!
My blog

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] HTML5 doctype

Post by bantu » Mon Sep 12, 2011 10:36 pm

callumacrae wrote:Don't bother with subsilver, I don't think it is XHTML valid anyway.
It used to be valid XHTML 1.0 Transitional. I guess the subsilver2 changes should just be reverted.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Tue Sep 13, 2011 6:42 am

bantu wrote:
callumacrae wrote:Don't bother with subsilver, I don't think it is XHTML valid anyway.
It used to be valid XHTML 1.0 Transitional. I guess the subsilver2 changes should just be reverted.
I agree with that. Subsilver2 is too entrenched in older XHTML to make for an easy transition over to HTML5 valid markup.

And considering that subsilver2 is sort of being pushed to the side in 3.1, I think its best not to waste any effort on trying to update it.
Has an irascible disposition.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 doctype

Post by callumacrae » Tue Sep 13, 2011 6:52 am

Has the doctype been changed?
Made by developers, for developers!
My blog

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] HTML5 doctype

Post by Oleg » Tue Sep 13, 2011 8:45 am

bantu wrote: It used to be valid XHTML 1.0 Transitional. I guess the subsilver2 changes should just be reverted.
Seems like a reasonable approach.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] HTML5 doctype

Post by Oleg » Tue Sep 13, 2011 8:45 am

callumacrae wrote:Has the doctype been changed?
Yes, and it was not mentioned anywhere which I now fixed.

Post Reply