[RFC|Merged] HTML5 doctype

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] HTML5 doctype

Post by igorw » Fri Jul 29, 2011 2:07 pm

Alright, I will make a PR which adds the HTML5 meta-tag:

Code: Select all

<meta charset="utf-8">
Becase, believe it or not, it's already supported in all browsers according to this, this and this (yep, makes sense now). Also, http-equiv is no longer a legal meta tag attribute in HTML5.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] HTML5 doctype

Post by callumacrae » Fri Jul 29, 2011 4:48 pm

igorw wrote:Also, http-equiv is no longer a legal meta tag attribute in HTML5.
According to the second link you posted, it is.
Made by developers, for developers!
My blog

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] HTML5 doctype

Post by igorw » Fri Jul 29, 2011 6:59 pm

Okay, turns out that http-equiv is allowed, as long as no meta-charset is also present.

Quoting the spec:
A document must not contain both a meta element with an http-equiv attribute in the Encoding declaration state and a meta element with the charset attribute present.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] HTML5 doctype

Post by Oleg » Fri Jul 29, 2011 11:38 pm

http://lists.w3.org/Archives/Public/pub ... /0550.html is pretty amazing. But we should test that it actually works.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Fri Sep 09, 2011 6:45 am

Well if HTML5 is going to be used (as it is now here at area51), gotta fix all them validation errors! Area51/phpBB3.1 not HTML5 valid
Has an irascible disposition.

User avatar
Miles Cellar
Registered User
Posts: 32
Joined: Thu Jul 07, 2005 7:45 am
Location: Paris, France
Contact:

Re: [RFC] HTML5 doctype

Post by Miles Cellar » Fri Sep 09, 2011 6:46 pm

VSE+ wrote:Well if HTML5 is going to be used (as it is now here at area51), gotta fix all them validation errors! Area51/phpBB3.1 not HTML5 valid
Well, Ascraeus will not be released today and is still under development, so of course all validation errors will be fixed in the final release, don't be afraid. ;)
AUTHOR OF THE FRENCH AND AMERICAN ENGLISH LANGUAGE PACK FOR PHPBB
GET THE LATEST LANGUAGE PACK NEWS…

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] HTML5 doctype

Post by naderman » Sun Sep 11, 2011 7:42 am

Maël Soucaze wrote:
VSE+ wrote:Well if HTML5 is going to be used (as it is now here at area51), gotta fix all them validation errors! Area51/phpBB3.1 not HTML5 valid
Well, Ascraeus will not be released today and is still under development, so of course all validation errors will be fixed in the final release, don't be afraid. ;)
Well while that might be true, someone will have to do the work. So please do submit patches to fix them :)

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] HTML5 doctype

Post by igorw » Sun Sep 11, 2011 1:39 pm

Good catch, as Nils said we'd be very grateful for any patches. :)

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Sun Sep 11, 2011 5:35 pm

naderman wrote:Well while that might be true, someone will have to do the work. So please do submit patches to fix them :)
Here is a patch with some fixes (replace "name" attribute with "id" in anchor tags):
https://github.com/phpbb/phpbb3/pull/367
Has an irascible disposition.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] HTML5 doctype

Post by VSE » Mon Sep 12, 2011 12:32 am

Discovered another HTML5 validation issue that I think needs some discussion first here.

The use of these old-fashioned table formatting attributes are not valid in HTML5 markup in the <table> element anymore, and should be styled by CSS:
"cellspacing"
"cellpadding"
"border"
"align"
"width"

However, the use of tables is pretty widespread in prosilver, especially in subsilver2 and also in the ACP. While class names already assigned to the tables, such as "table1" in the mcp pages, are common, the values of these formatting attributes tags can vary between all the different tables of class "table1"

So how best to address converting this over to CSS?
Has an irascible disposition.

Post Reply