[RFC|Merged] Delete "Confirm e-mail address"

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by Oleg » Fri Dec 23, 2011 3:27 am

Could not test registration due to http://tracker.phpbb.com/browse/PHPBB3-10477.

There are two other locations where we ask for email confirmation. One is installer, and for that I have https://github.com/p/phpbb3/commit/1469 ... c2944e21d3 (untested).

The other one is acp, and I think it's safe to remove email confirmation there. Browsers only autocomplete email addresses when the input field is empty, and we cannot ever have it empty, can we?

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by MichaelC » Fri Dec 23, 2011 8:31 am

What about edit account settings in UCP?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by imkingdavid » Fri Dec 23, 2011 9:13 pm

Unknown Bliss wrote:What about edit account settings in UCP?
imkingdavid wrote:The pull request is ready and has deleted the field from both the registration form and the profile registration details form.
Same thing.

EDIT: I have also removed it from acp_users. Oleg, is it okay if I implement your commit into my patch?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by Oleg » Sat Dec 24, 2011 1:07 am

Yes, I was hoping you'd say that ;) (you'll need to fix the commit message).

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by Oleg » Sun Dec 25, 2011 6:49 am

Not sure what you did with my commit but you could have cherry-picked it and then amended it to rewrite the commit message:

git cherry-pick <sha1>
git commit --amend

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by imkingdavid » Sun Dec 25, 2011 1:40 pm

Oleg wrote:Not sure what you did with my commit but you could have cherry-picked it and then amended it to rewrite the commit message:

git cherry-pick <sha1>
git commit --amend
I just did it the "hard" way by performing all the actions myself. I didn't know about that method, but I'll keep that in mind for future reference.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by Oleg » Sun Dec 25, 2011 7:49 pm

And I just found out we already have a ticket to change email addresses on unactivated user accounts:

http://tracker.phpbb.com/browse/PHPBB3-9894

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by imkingdavid » Sun Dec 25, 2011 8:46 pm

Oleg wrote:And I just found out we already have a ticket to change email addresses on unactivated user accounts:

http://tracker.phpbb.com/browse/PHPBB3-9894
Well then there's really no reason not to do this patch if that is going to be implemented as well.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by naderman » Wed Dec 28, 2011 11:40 am

Indeed I think that would be the proper solution, so let's merge this one.

As for the commit, it's also better to cherry-pick commits, simply because we want to keep track of who wrote what originally, and Oleg will not show up as the author of that commit now. You can change the author of the latest commit by running git commit --amend --author "A Name <email@example.com>".

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Delete "Confirm e-mail address" from registration

Post by imkingdavid » Wed Dec 28, 2011 6:30 pm

naderman wrote:Indeed I think that would be the proper solution, so let's merge this one.

As for the commit, it's also better to cherry-pick commits, simply because we want to keep track of who wrote what originally, and Oleg will not show up as the author of that commit now. You can change the author of the latest commit by running git commit --amend --author "A Name <email@example.com>".
All done, I also changed the commit message to his original one and prepended it with the proper branch name.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply