[RFC|Merged] Normalise internet protocol version 6 addresses

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

[RFC|Merged] Normalise internet protocol version 6 addresses

Post by bantu » Mon Sep 27, 2010 3:17 pm

As a proper fix for http://tracker.phpbb.com/browse/PHPBB3-9091 and for other reasons outlined in http://tracker.phpbb.com/browse/PHPBB3-9746 etc. we came up with some normalisation for internet protocol addresses.

The changeset is medium-sized, therefore I'd like to ask for comments and reviews.

Tracker Ticket: http://tracker.phpbb.com/browse/PHPBB3-9746
Proposed Patch: http://github.com/bantu/phpbb3/compare/ ... icket/9746

I'm also pretty sure I'm missing some locations where phpbb_ip_normalise() should be called.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Normalise internet protocol version 6 addresses

Post by bantu » Wed Oct 13, 2010 11:10 pm

Set to awaiting merge.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Normalise internet protocol version 6 addresses

Post by bantu » Sun Oct 17, 2010 6:45 pm

We should probably normalise IP addresses that are already in the database. It should be possible to select all ip addresses containing the character ":" from all tables.

Post Reply