[RFC] Cache plugins refactoring

[igorw]

The cache "plugins" system is a mess. The plugin defines the base class (must have a certain name), phpBB provides a class that extends the plugin.

Currently

Code: Select all

// I am a plugin
class acm
{
}

Code: Select all

// I am phpBB
class cache extends acm
{
}

Should be

Code: Select all

// I am phpBB
abstract class phpbb_acm_base implements phpbb_acm_interface
{
}

Code: Select all

// I am a plugin
class phpbb_acm_xcache extends phpbb_acm_base
{
}

Code: Select all

// I am an awesome plugin
class phpbb_acm_awesome_plugin extends phpbb_acm_other_plugin
{
}

Details

• Proper use of polymorphism
• Remove includes/cache.php (or make it use a acm instance instead of extending acm)
• Use class loader
• Abstract base class and interface
• All plugins need to be refactored