[RFC|Merged] No db storage of stylesheets and templates

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by nickvergessen » Tue Oct 11, 2011 12:01 pm

We also have now 10+ requests to the server, as every file is grabbed by his own, and not just one style.php
Member of the Development-TeamNo Support via PM

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by VSE » Wed Oct 12, 2011 5:26 am

Why not just make 1 stylesheet, and have it clearly delineated by comments to separate the bidi, colors, common, links, etc etc...?

/**************** Colours *****************/
all your colors css here

/****************Common*****************/
all your common css here

Just never go back to style.php... (see: viewtopic.php?f=108&t=41537&start=10#p229801)
Has an irascible disposition.

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by Arty » Wed Oct 12, 2011 6:12 pm

I'm with VSE+ on that one. All text editors have search function, so separating theme into many css files isn't necessary.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by naderman » Wed Oct 12, 2011 7:45 pm

I agree. Is this going to cause major problems for MODs or styles in any way?

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by Arty » Wed Oct 12, 2011 10:01 pm

It will only make things easier because users won't have to search many css files to find a selector. Mods will only have to change whatever.css to stylesheet.css in instructions.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by nickvergessen » Wed Oct 12, 2011 10:02 pm

I'd say not more than it does anyway (removing imagesets)
But when we merge it ALL mods having css will be broken.
Member of the Development-TeamNo Support via PM

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by naderman » Wed Oct 12, 2011 11:03 pm

Well I suppose the advantages outweigh the cost here, so who's going to write the patch? :)

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by nickvergessen » Wed Oct 12, 2011 11:31 pm

Again, like on the removing of imagesets, the patch should contain a script, so it's easier for style authors to do the same?
Member of the Development-TeamNo Support via PM

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by naderman » Wed Oct 12, 2011 11:45 pm

Not sure if you need a script to concatenate a few files?

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC|Merged] No db storage of stylesheets and templates

Post by callumacrae » Thu Oct 13, 2011 5:36 am

naderman wrote:Not sure if you need a script to concatenate a few files?
That's what I read it as.

EDIT: I read your post wrong >_<
Made by developers, for developers!
My blog

Post Reply