[RFC|Merged] Rename MSNM to WLM

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

[RFC|Merged] Rename MSNM to WLM

Post by nickvergessen »

As per viewtopic.php?f=3&t=24122 I think we should do this for 3.1

Pull Request: https://github.com/phpbb/phpbb3/pull/23
Member of the Development-TeamNo Support via PM

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Rename MSNM to WLM

Post by EXreaction »

Please do not rename the column in the database, that's just asking for compatibility problems. :/

Changing the language value and image should be enough.

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Rename MSNM to WLM

Post by igorw »

I agree with nathan. While it would be nice to have it all cleaned, it does not justify the cost (upgrade pains, compatibility with MODs...). IMO not worth it.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Rename MSNM to WLM

Post by naderman »

I agree with Igor and Nathan on this.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Rename MSNM to WLM

Post by naderman »

Alright so this is accepted, but without the column name change. So UI only.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Rename MSNM to WLM

Post by nickvergessen »

Member of the Development-TeamNo Support via PM

ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: [RFC|Accepted] Rename MSNM to WLM

Post by ToonArmy »

The image doesn't look right to me.
Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Rename MSNM to WLM

Post by naderman »

Mind explaining that?

ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: [RFC|Accepted] Rename MSNM to WLM

Post by ToonArmy »

naderman wrote:Mind explaining that?
The prosilver shades look wrong, probably just my eyes and monitors.
Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Rename MSNM to WLM

Post by naderman »

I guess, looks alright to me.

Post Reply