These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
ToonArmy wrote:Could we use the build script to set the @version information to the release version, it's always been kind of handy as a quick check.
Could be useful but it'd have to stay in sync, meaning changing all files with each update (or building something special into the auto updater). Not sure if it's worth the effort.
Use the built-in isset() function
Begin picky here, isset is not a function but a language construct. Looks good.
ToonArmy wrote:Could we use the build script to set the @version information to the release version, it's always been kind of handy as a quick check.
Could be useful but it'd have to stay in sync, meaning changing all files with each update (or building something special into the auto updater). Not sure if it's worth the effort.
I like the idea, but the auto-updater would be huge+, not the best for 3.1 I'd say. Maybe for 4.0.
/**
*
* @package {PACKAGENAME}
* @copyright (c) 2010 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU Public License, version 2
*
*/
This should only apply to files new to the develop (ascraeus) branch.
i would accept this change for phpbb core code, but for mods ?
I'm using SVN VCS (Googlecode), and so i don't see the point of removing * @version $Id: $.
sajaki wrote:i would accept this change for phpbb core code, but for mods ?
I'm using SVN VCS (Googlecode), and so i don't see the point of removing * @version $Id: $.
I don't foresee us enforcing this at all for MODs so don't worry about it. While we have decided to use github, which is part of the reason we are removing this line, everyone else can use whatever service they'd like to use (SF, GCode, etc.) so this part of the guidelines may not apply for all MOD writers anyways.
ToonArmy wrote:Could we use the build script to set the @version information to the release version, it's always been kind of handy as a quick check.
Could be useful but it'd have to stay in sync, meaning changing all files with each update (or building something special into the auto updater). Not sure if it's worth the effort.
I like the idea, but the auto-updater would be huge+, not the best for 3.1 I'd say. Maybe for 4.0.
if we only do that, for files that got changed, it should be not much more work than it is now right?
Member of the Development-Team — No Support via PM