[RFC|Merged] Resuming for attachments / HTTP range support

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

[RFC|Merged] Resuming for attachments / HTTP range support

Post by bantu » Mon May 31, 2010 11:28 am

Proposal
Inspired by: viewtopic.php?p=209196#p209196 I suggest to implement support for HTTP range requests (RFC 2616 Section 14.35) in download/file.php

Why?
  • Faster downloads when a download of a big file has been interrupted.
  • Faster downloads when a download via a slow connection has been interrupted.
  • Sending parts of a file instead of the whole file decreases traffic.
Discussion
  • I wonder why we do not already support this as the implementation doesn't seem to be too complicated.
  • Patch is minimally-invasive and could also go into 3.0.x.
Implementation / Patch
Work in progress is at http://github.com/bantu/phpbb3/compare/ ... icket/9627

Tracker
Related ticket: http://tracker.phpbb.com/browse/PHPBB3-9627

References
http://www.w3.org/Protocols/rfc2616/rfc ... l#sec14.35
http://www.php.net/manual/en/function.fread.php#84115

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by A_Jelly_Doughnut » Mon May 31, 2010 1:44 pm

Looks good to me, but I don't see any compelling reason to put it in 3.0.x.

I'd suspect it was not implemented originally because most boards would not be attaching very large files, and range support generally only gives a gain on large files.
A_Jelly_Doughnut

User avatar
Arman_Ajn
Registered User
Posts: 12
Joined: Fri May 21, 2010 6:43 pm
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by Arman_Ajn » Mon May 31, 2010 3:38 pm

Some countries still use dial up connection ! in my own country for instance 90% of internet users are using dial up 56Kbps and just 10% of them use ADSL! so the resume capability is very necessary for them!
i think there are still locations with poor internet speed ...
they really need resume support !

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by keith10456 » Tue Jun 01, 2010 1:08 am

Arman_Ajn wrote:Some countries still use dial up connection ! in my own country for instance 90% of internet users are using dial up 56Kbps and just 10% of them use ADSL! so the resume capability is very necessary for them!
i think there are still locations with poor internet speed ...
they really need resume support !
I didn't see the need for this until the above point was made. Considering phpBB is global then this feature should definitely be added.

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by Meis2M » Tue Jun 01, 2010 6:17 pm

Tnx bantu for ur work.
this tools very useful. ;)

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by naderman » Wed Jun 02, 2010 10:54 am

Indeed lets go for this, but I agree with josh that this is for 3.1, not 3.0.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by bantu » Wed Jun 02, 2010 11:40 am

Rebased commit to be on develop instead of develop-olympus.
New link: http://github.com/bantu/phpbb3/compare/ ... icket/9627

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by bantu » Fri Jun 04, 2010 8:47 am

I assume the download counter is not supposed to be updated when a file is delivered partially. This would have to be adjusted as well.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Resume support for attachments / HTTP range suppor

Post by bantu » Wed Jun 23, 2010 2:45 pm

Okay, I've added 4 more commits to the branch. The download counter is no longer incremented when a file is requested partially.

This has to be tested with various browsers, I only tested this with wget on the command line so far.

But otherwise I'd say this is ready for integration.

For the lazy folks: The branch is still at http://github.com/bantu/phpbb3/compare/ ... icket/9627

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Resuming for attachments / HTTP range sup

Post by bantu » Sun Jul 25, 2010 8:54 pm

I have split off the discussion about "direct downloads" because the ability to resume an attachment download is not always given[0] with the proposed patch. Thus the discussion is not directly related to this topic.

New topic is at viewtopic.php?f=84&t=33495#p211170

[0] viewtopic.php?p=211197#p211197

Post Reply