[RFC|Accepted] Avatar improvements, Gravatar

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Sam
Registered User
Posts: 31
Joined: Fri Jan 23, 2009 10:24 pm

[RFC|Accepted] Avatar improvements, Gravatar

Post by Sam » Sun Apr 25, 2010 9:33 am

This comes mainly out of a tracker post naderman made, which simply proposes the idea of interfacing with external avatar services, namely Gravatar.
http://tracker.phpbb.com/browse/PHPBB3-9498

I propose a patch, which at this time has been packed in a MODX file compatible with phpBB 3.0 for your viewing pleasure. (Download)

This is a very simple edit, all it does is add a new constant (avatar type), create a new function handle the Gravatars, and last but not least, creates an option on the user control panel to use the Gravatar associated with the user's email.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-9498
Patch: https://github.com/ckwalsh/phpbb3/tree/ ... %2Favatars

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Avatar improvements, Gravatar

Post by igorw » Sun Apr 25, 2010 9:43 am

Since this touches the same subject, I'd like to suggest something similar to what I said here.

One of the things preventing phpBB to run in cluster ("cloud") environments is the way it depends on the file system. There is no easy way to change the storage of files. And avatars are also files. Of course, one could just use remotely hosted avatars, but it's not the ideal solution.

By providing an abstract avatar interface the avatars could be very extensible, allowing integration with third-party services such as gravatar -- something I'd love to see, by the way.

Backward compatibility would probably have to be broken, however.

EDIT: I see this has also been touched in the ticket you linked to.

User avatar
Kellanved
Former Team Member
Posts: 407
Joined: Sun Jul 30, 2006 4:59 pm
Location: Berlin

Re: [RFC] Avatar improvements, Gravatar

Post by Kellanved » Sun Apr 25, 2010 10:06 am

Adding a new avatar type and abstracting from the storage of files are two different issues. Storage abstraction is something we have to consider, but it wouldn't be limited to avatars. On the other hand, introducing other avatar types might be easier to do by providing the appropriate hooks.
No support via PM.
Trust me, I'm a doctor.

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Avatar improvements, Gravatar

Post by igorw » Sun Apr 25, 2010 10:31 am

True.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Avatar improvements, Gravatar

Post by MichaelC » Sun Apr 25, 2010 12:09 pm

I would support this idea.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
Highway of Life
Registered User
Posts: 1399
Joined: Tue Feb 08, 2005 10:18 pm
Location: I'd love to change the World, but they won't give me the Source Code
Contact:

Re: [RFC] Avatar improvements, Gravatar

Post by Highway of Life » Mon Apr 26, 2010 11:50 pm

Igor you made an interesting point, and I think changing the way files are delivered would open up the code so you could create, for example, interfaces to third party objects. Such as uploading attachments to Amazon S3. But is that a different RFC?
Image

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Avatar improvements, Gravatar

Post by igorw » Tue Apr 27, 2010 12:18 am

Yep. It would rather go into this topic because it's a different matter, as Henry stated.

User avatar
Kellanved
Former Team Member
Posts: 407
Joined: Sun Jul 30, 2006 4:59 pm
Location: Berlin

Re: [RFC] Avatar improvements, Gravatar

Post by Kellanved » Tue Apr 27, 2010 7:38 pm

Actually, it would be a different RFC. We have:

-Storing files outside the root -> should be a feature of the storage API for uploads
-storage API - RFC forthcoming, although it'll be a lot like cache
-new avatar types/delivery options - should be handled by proposing hooks to alter/add avatar options; the storage API might be able to provide direct links where safe
No support via PM.
Trust me, I'm a doctor.

User avatar
Dog Cow
Registered User
Posts: 270
Joined: Wed May 25, 2005 2:14 pm

Re: [RFC] Avatar improvements, Gravatar

Post by Dog Cow » Fri Apr 30, 2010 3:45 pm

Highway of Life wrote: Such as uploading attachments to Amazon S3. But is that a different RFC?
Or storing the forum posts on S3.

User avatar
Kellanved
Former Team Member
Posts: 407
Joined: Sun Jul 30, 2006 4:59 pm
Location: Berlin

Re: [RFC] Avatar improvements, Gravatar

Post by Kellanved » Sat May 01, 2010 11:31 pm

Posts, being stored in the database are utterly outside of this RFC. You can place your database in the cloud just fine - even with 3.0.
No support via PM.
Trust me, I'm a doctor.

Post Reply