[RFC|Merged] Switch to PHP timezone handling

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Tue Jun 12, 2012 6:27 pm

Fixed ACP and subsilver2

PR: https://github.com/phpbb/phpbb3/pull/843

Todo:
  • Add function to calculate the unix timestamp of a given user date and time
  • Add code to update
  • Write (functional) tests
Member of the Development-TeamNo Support via PM

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Mon Jun 18, 2012 1:14 pm

Apart from additional functional tests, the work should be complete here.
Member of the Development-TeamNo Support via PM

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Thu Jun 21, 2012 10:02 am

This is currently pending because some db functions need to get merged first:
https://github.com/phpbb/phpbb3/pull/853
Member of the Development-TeamNo Support via PM

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Switch to PHP timezone handling

Post by naderman » Thu Jul 19, 2012 3:50 pm

This change has been merged.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC|Merged] Switch to PHP timezone handling

Post by EXreaction » Fri Jul 20, 2012 3:25 pm

This seems rather confusing and difficult to set in the UCP.

After selecting a timezone, I am given this massive unorganized list to sort through in order to find my local area. The only thing that selecting a timezone seems to do is to display an identifier in the huge list of areas showing where that timezone starts. What I think might be better is to use some javascript to hide all timezones outside of +-1 that was selected in the first place, that would make finding the correct one significantly easier.

The identifiers of all the sections might be actually better just kept in place all the time as well, so that people can see there are different sections sorted by timezone, then alphabetical (otherwise someone would just assume it is alphabetical, which makes finding something confusing).

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Switch to PHP timezone handling

Post by naderman » Fri Jul 20, 2012 3:54 pm

Actually the list you see is only places that have exactly your current local time. With the current implementation after selecting a time you do not see any locations that have a different time than yours.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC|Merged] Switch to PHP timezone handling

Post by EXreaction » Fri Jul 20, 2012 7:15 pm

Is there a bug or something strange on here?
Attachments
Untitled-1.png
(19.58 KiB) Downloaded 4807 times

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Switch to PHP timezone handling

Post by naderman » Fri Jul 20, 2012 8:00 pm

Seems like it, I only get to see the section corresponding to my selected time in the first dropdown. Which browser and version are you using?

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC|Merged] Switch to PHP timezone handling

Post by EXreaction » Fri Jul 20, 2012 8:50 pm

Chrome 20.0.1132.57

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Merged] Switch to PHP timezone handling

Post by naderman » Fri Jul 20, 2012 9:03 pm

nickvergessen should check that out then, best create a ticket with the screenshot for him.

Post Reply