[RFC|Merged] Switch to PHP timezone handling

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
AmigoJack
Registered User
Posts: 92
Joined: Wed May 04, 2011 7:47 pm
Location: グリーン ヒル ゾーン
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by AmigoJack » Tue Aug 30, 2011 8:07 am

It's not that we need to actually pre-select the right time zone - the whole list could be filtered, so only time zones show up which are +/- 2 or 3 hours of the current local time. Because there is no rule that daylight saving is always 1 hour delta.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Wed Mar 14, 2012 11:03 pm

Oleg can you rebase this on develop, there are some strange conflicts in install/database_update.php with your last commit.
Member of the Development-TeamNo Support via PM

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by Oleg » Thu Mar 15, 2012 3:08 am

I got as far as plurals for now.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Tue Jun 05, 2012 7:52 pm

I updated the branch of oleg to develop and worked a bit on it:
https://github.com/nickvergessen/phpbb3 ... z-handling

The selection is now made in 2 steps:
1. Select your current time (limits the number of timezones in step 2)
2. Select the actual timezone
javascript.png
(68.64 KiB) Downloaded 4953 times
Without Javascript, we can not do much, but give the hole list:
noscript.png
(52.93 KiB) Downloaded 4953 times
Member of the Development-TeamNo Support via PM

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by naderman » Tue Jun 05, 2012 10:09 pm

Sounds good.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by Oleg » Wed Jun 06, 2012 6:01 am

I like, I think.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by naderman » Wed Jun 06, 2012 8:43 am

Please make sure, the feature PR includes a functional test.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Wed Jun 06, 2012 3:38 pm

Todo:
  • Change selection in ACP
  • Change selection in subsilver2
  • Add function to calculate the unix timestamp of a given user date and time
  • Add code to update
  • Write tests
Member of the Development-TeamNo Support via PM

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by Oleg » Thu Jun 07, 2012 9:10 am

From what I recall language had to be changed to use 3.1 plurals and migrations/install code needed to be written.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Switch to PHP timezone handling

Post by nickvergessen » Thu Jun 07, 2012 5:29 pm

I would not know, where plurals are used, but I will review it. thanks for rementioning.
Member of the Development-TeamNo Support via PM

Post Reply