phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC|Merged] Switch to PHP timezone handling

These requests for comments have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby AmigoJack » Tue Aug 30, 2011 8:07 am

It's not that we need to actually pre-select the right time zone - the whole list could be filtered, so only time zones show up which are +/- 2 or 3 hours of the current local time. Because there is no rule that daylight saving is always 1 hour delta.
User avatar
AmigoJack
Registered User
 
Posts: 59
Joined: Wed May 04, 2011 7:47 pm
Location: グリーン ヒル ゾーン

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby nickvergessen » Wed Mar 14, 2012 11:03 pm

Oleg can you rebase this on develop, there are some strange conflicts in install/database_update.php with your last commit.
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby Oleg » Thu Mar 15, 2012 3:08 am

I got as far as plurals for now.
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby nickvergessen » Tue Jun 05, 2012 7:52 pm

I updated the branch of oleg to develop and worked a bit on it:
https://github.com/nickvergessen/phpbb3 ... z-handling

The selection is now made in 2 steps:
1. Select your current time (limits the number of timezones in step 2)
2. Select the actual timezone
javascript.png


Without Javascript, we can not do much, but give the hole list:
noscript.png
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby naderman » Tue Jun 05, 2012 10:09 pm

Sounds good.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby Oleg » Wed Jun 06, 2012 6:01 am

I like, I think.
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby naderman » Wed Jun 06, 2012 8:43 am

Please make sure, the feature PR includes a functional test.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby nickvergessen » Wed Jun 06, 2012 3:38 pm

Todo:
  • Change selection in ACP
  • Change selection in subsilver2
  • Add function to calculate the unix timestamp of a given user date and time
  • Add code to update
  • Write tests
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby Oleg » Thu Jun 07, 2012 9:10 am

From what I recall language had to be changed to use 3.1 plurals and migrations/install code needed to be written.
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [RFC|Accepted] Switch to PHP timezone handling

Postby nickvergessen » Thu Jun 07, 2012 5:29 pm

I would not know, where plurals are used, but I will review it. thanks for rementioning.
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Previous Next

Return to [3.1/Ascraeus] Merged RFCs

Who is online

Users browsing this forum: No registered users and 6 guests