nn- wrote:One thing I'm wondering is why does cron.php need append_sid?
Based on the current set of tasks it should not. Perhaps there are tasks that could take care of something session-based, but I cannot really think of a use case.
nn- wrote:If anyone wants to help, please test forum pruning via both phpbb cron and system cron.
How would one test this via system cron? I didn't see any specific code for this, so would it be something like "curl http://localhost/phpBB/cron.php
I have brought my copy phpBB up-to-date and merged develop into feature/system-cron, which gives a bit of a better view on github: http://github.com/evil3/phpbb3/compare/ ... ystem-cron
nn- wrote:I also want the cron system to be usably documented. Documentation requests and suggestions are welcome.
The most important would be a little guide explaining how to create cron tasks, then parameterized tasks. I don't really see the need for additional documentation on the internals. They are already commented pretty well. Perhaps there could be some sort of flow chart describing in what order the methods are called (eg. is parse_parameters() called before X?).
nn- wrote:Is anyone going to bother looking at and maybe committing this code, or have I entirely wasted the time I put into it?
I have looked at it several times. I have not yet had time to test it, it does however looks very good. Most certainly by far more clean and extensible, I like it.