[RFC|Merged] Link global announcements to forums

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Global Announcements in 3.1

Post by nickvergessen » Thu Mar 11, 2010 3:47 pm

Updated the git-branch.
The only things that are still missing are:
  • The tracking system ...
  • Update-code: would be best if there weren't any while updating, but we can not ensure this right?
Member of the Development-TeamNo Support via PM

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Global Announcements in 3.1

Post by naderman » Thu Mar 11, 2010 8:58 pm

No we cannot, we will have to move them somewhere. Not really sure what the best approach for that is.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Global Announcements in 3.1

Post by nickvergessen » Thu Mar 11, 2010 10:58 pm

Okay, seems like it wasn't that hard to change the tracking.

The only thing left on the list now is, how to handle existing GAs.
The rest is ready for testing. :geek:

http://github.com/nickvergessen/phpbb3/ ... ouncements
Member of the Development-TeamNo Support via PM

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Global Announcements in 3.1

Post by imkingdavid » Fri Mar 12, 2010 2:03 am

I'm not sure if this was mentioned since I read about half of the posts in this topic, but what is meant by "linking" to the GA from other forums? Because I like how it currently shows the forum name in breadcrumbs of the forum that the user clicked into the GA from. In phpBB 2.0 I believe that if you were to click on a GA, it would just take you to that topic in the forum it was originally posted in, which effectively makes it just a "link" to another topic. However, I see value in keeping it where it shows the forum you were in when you click on the GA in the breadcrumbs. Maybe I don't understand what you mean by "linking", but if it is how phpBB 2 did it, I'm not sure I'm for it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Global Announcements in 3.1

Post by naderman » Fri Mar 12, 2010 2:11 am

phpBB2 never had global announcements. But yes we do mean linking in the way you describe. I think it makes things a lot clearer to users who might otherwise be confused by the read/unread behaviour and might not realise that they are visiting a topic visible in multiple forums. It should however be visible on viewforum that it is a "redirect" to another forum.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Global Announcements in 3.1

Post by imkingdavid » Fri Mar 12, 2010 2:17 am

naderman wrote:phpBB2 did never have global announcements. But yes we do mean linking in the way you describe. I think it makes things a lot clearer to users who might otherwise be confused by the read/unread behaviour and might not realise that they are visiting a topic visible in multiple forums. It should however be visible on viewforum that it is a "redirect" to another forum.
Ahh good point. I haven't use 2.0 for a long time except on one forum that is reluctant to update. I guess they have a Global Announcement MOD installed. Anyway, yeah I guess if it is shown that it will move them to a different forum, that would be OK.

Although maybe you could put something in the URL to retrieve through GET to let them get back to the previous forum?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Global Announcements in 3.1

Post by nickvergessen » Fri Mar 12, 2010 10:43 am

We could add the same thing we also have in the search:

Code: Select all

» in {FORUM_NAME}
tmp.png
(36.46 KiB) Downloaded 3651 times
Or even use something like the topic-moved icon. Than it should be quite clear, that the topic is in an other forum and you get "redirected". Problem on the moved-icon thing is, we do not have an unread-moved icon yet.
Member of the Development-TeamNo Support via PM

code reader
Registered User
Posts: 653
Joined: Wed Sep 21, 2005 3:01 pm

Re: Global Announcements in 3.1

Post by code reader » Fri Mar 12, 2010 3:56 pm

maybe....
i am not sure if this is the case - i did not actually read all the recent changes to the code.
however, i thought of something that may make life easier (or not). if i'm wrong in my assumption, or if it doesn't make life any easier just scrap it.

so here goes:
IMO, global announcement is not "global topic".
i do not see a need for "global topic".
what it means is that global announcement should not be reply-able, which may make the whole permission treatment much simpler: anyone can read a global announcement, and nobody can reply, thank you very much. so when dealing with global announcement, you should never have to consult the user's permissions.

peace.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Global Announcements in 3.1

Post by nickvergessen » Fri Mar 12, 2010 4:01 pm

As it was possible to reply in the past (and that makes sense for me) it should also be in future.

The only difference Global Announcements have from normal Announcements, in the dev-branch I made:
  • GA are viewed in all forums you're allowed to see
  • GA are viewed in the first page of the UCP
Member of the Development-TeamNo Support via PM

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: Global Announcements in 3.1

Post by MichaelC » Wed Mar 17, 2010 6:05 pm

Maybe the posting user has a tab on the attachments on who can access that GA, but in the ACP 'Special Groups could be set that always have at least certain permissions meaning members could not stop moderators and admins seeing them and moderators could not stop admins. But having it so that only admins can overide the who can view permissions meaning admins could stop moderators seeing it, but members and moderators could not stop moderators seeing it.

Its complicated but could probably work with alot of IF statments?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply