phpBB 3.2.10-RC2 released

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 371
Joined: Thu Sep 16, 2004 9:02 am
Contact:

Re: phpBB 3.2.10-RC2 released

Post by Paul »

No, we always use com to test rc releases before the actual release

User avatar
3Di
Registered User
Posts: 863
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: phpBB 3.2.10-RC2 released

Post by 3Di »

Paul wrote:
Fri Jun 12, 2020 7:04 am
No, we always use com to test rc releases before the actual release
As I said that's new to me, thanks.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
rxu
Registered User
Posts: 151
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: phpBB 3.2.10-RC2 released

Post by rxu »

kasimi wrote:
Thu Jun 11, 2020 8:20 pm
wildcard searches aren't working as expected.
That could be subject to particular .com Sphinx config, as described like here http://sphinxsearch.com/docs/current.ht ... prefix-len
But can't bet :)
Image

welshpaul
Registered User
Posts: 5
Joined: Tue Jun 02, 2020 10:16 am

Re: phpBB 3.2.10-RC2 released

Post by welshpaul »

I use php 7.2.31 and i'm seeing the following php error when using an extension that makes use of the request class:
The each() function is deprecated
I believe it is caused by a line of code in the following file:
phpBB3/phpbb/request/type_cast_helper.php

More so this:

Code: Select all

list($default_key, $default_value) = each($default);
Fixed in 3.3.0 but not in 3.2.x:
https://github.com/phpbb/phpbb/pull/5798/files

I thought phpBB 3.2.x was compatible with php 7.0, 7.1 and 7.2 but not 7.3 and up?
https://github.com/phpbb/phpbb/pull/4624

User avatar
rxu
Registered User
Posts: 151
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: phpBB 3.2.10-RC2 released

Post by rxu »

welshpaul
Normally you shouldn't get deprecation warnings on production board because of the error reporting level used for phpBB:

Code: Select all

// Report all errors, except notices and deprecation messages
$level = E_ALL & ~E_NOTICE & ~E_DEPRECATED;
error_reporting($level);
Why are you getting it?
Image

welshpaul
Registered User
Posts: 5
Joined: Tue Jun 02, 2020 10:16 am

Re: phpBB 3.2.10-RC2 released

Post by welshpaul »

rxu wrote:
Wed Jul 08, 2020 11:59 am
Why are you getting it?
I am seeing the error via an extension that reports to bugsnag via an api to debug another issue.

While I understand that the depreciated functions still exists and that these functions will not be available in future versions I just thought such issues had been updated alongside 3.3.0.
Last edited by welshpaul on Wed Jul 08, 2020 12:20 pm, edited 1 time in total.

User avatar
rxu
Registered User
Posts: 151
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: phpBB 3.2.10-RC2 released

Post by rxu »

So it should be ok on production. Also despite the function is deprecated it works as expected, so in common it doesn't mean that 3.2 is not PHP 7.2 compatible.
Image

welshpaul
Registered User
Posts: 5
Joined: Tue Jun 02, 2020 10:16 am

Re: phpBB 3.2.10-RC2 released

Post by welshpaul »

Yea I should have phrased things better. I needed to resolve this though as the free tier offered by Bugsnag is limited to reporting X amount of errors and I kept going over that allowance due to these deprecated errors. Anyway, resolved this issue on my board.

User avatar
Talk19Zehn
Registered User
Posts: 8
Joined: Sat Jul 18, 2020 9:05 am

Re: phpBB 3.2.10-RC2 released

Post by Talk19Zehn »

Hello, what is the reason <hr class = "divider" /> was deleted in this template: viewtopic_ body.html

HTML diff 3.2.9_to_3.2.10-RC1 (ff => 3.2.10-RC2, 3.3.1-RC1)

Code: Select all

 - <hr class = "divider" />
<! - EVENT viewtopic_body_postrow_post_after ->
<! - END postrow -> 
?

The demarcation was unique and correct and well suited for the visually impaired to create a separation (color-visible feature) between the contributions. In addition, decorative graphics, lines, etc. could be declared via the CSS and subsequently used at that position.

In my opinion, the element hr.divider in the Prosilver standard style was a particularly good separating feature for the definition of a delimitation between the posts.

My suggestion is to undo the removal: Inheriting the template (viewtopic_ body.html) changes designs that used this class.

Small abolition with a big impact ...

Regards

User avatar
3Di
Registered User
Posts: 863
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: phpBB 3.2.10-RC2 released

Post by 3Di »

^^ BBcode code needs an edit to separate your statement.
(edit: somebody did it for you without leaving his mark :geek: )



There were good reasons: https://tracker.phpbb.com/browse/PHPBB3-16445

Also, no one forbids you to copy the viewtopic_ body.html file in your style and add your missing line and its CSS.
You don't necessarily have to inherit everything.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

Post Reply