URL with post number (limits of the feature)

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
pierredu
Registered User
Posts: 33
Joined: Sat Dec 05, 2015 7:21 am

URL with post number (limits of the feature)

Post by pierredu » Sat Oct 21, 2017 4:23 pm

Hi,

I find that the fact that the URL only contains the post number and not both the topic number and the post number is fine.

However, I just observed a side effect which is less palatable.

I had sent a pm to somebody about a topic, with remarks about its contents and with the proposal to delete his two messages and my two messages, at the end, because they were not useful anymore after some modification of former posts. In my message box, the URL stored was of the form https://www.insecte.org/forum/viewtopic.php?p=1412530#p1412530. And, you guess it, if I click on this link after the deletion, I get a message about a topic which doesn't exist.

I don't know how it would be possible to keep the link between deleted posts and their topics in some place otherwise than in the URL.

User avatar
david63
Registered User
Posts: 215
Joined: Mon Feb 07, 2005 7:23 am
Location: Lancashire, UK

Re: URL with post number (limits of the feature)

Post by david63 » Sun Oct 22, 2017 7:17 am

I must be missing something here - how can you have a link to something that does not exist? If you have deleted the post/topic then that error message is correct - it would be the same if the post was moved to another forum that a user does not have permission for.
David
Remember: You only know what you know -
and you do not know what you do not know!

User avatar
pierredu
Registered User
Posts: 33
Joined: Sat Dec 05, 2015 7:21 am

Re: URL with post number (limits of the feature)

Post by pierredu » Sun Oct 22, 2017 8:20 am

Before the deletion, the link works. After deleting the last 4 posts in the topic (there remain 10 or more in the topic), the link doesn't work anymore. Because of the syntax used (post number only).
If the syntax was forum number + post number, I think it would work. Before 3.1, links had always f + p numbers.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 789
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: URL with post number (limits of the feature)

Post by hanakin » Sun Oct 22, 2017 4:24 pm

I do not think they ever had f+p for a past, they may have had t#p currently when viewing a topic you have f+t so what you are really asking for is f+t#p instead of f+t+p#p I am not sure why we use f+t+p#p. The only reason I can see to require the +p is for paging so the link knows what page to go too. so really its an issue with paging

User avatar
pierredu
Registered User
Posts: 33
Joined: Sat Dec 05, 2015 7:21 am

Re: URL with post number (limits of the feature)

Post by pierredu » Sun Oct 22, 2017 7:36 pm

Sorry for the mistake. I meant t+p numbers.
You know, I'm not asking for anything. I'm just pointing a (borderline) case where the simplification of omitting the topic number brings some problems.
Just to know that this can happen...

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: URL with post number (limits of the feature)

Post by Vinny » Mon Oct 23, 2017 6:10 am

viewtopic.php?f=126&t=52441#p304646 (forum id+topic id+post id)
viewtopic.php?t=52441#p304646 (topic id+post id)
viewtopic.php?p=304646#p304646 (post id)

these 3 links take you to the same post, in addition "t+p numbers" already exist.

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: URL with post number (limits of the feature)

Post by Louis7777 » Mon Oct 23, 2017 8:09 am

There's also a known bug with having links in this format viewtopic.php?p=1412530#p1412530 or this viewtopic.php?t=1412530#p1412530 without the "f" parameter. Note that the second format without the fragment is what we have for canonical URL.

The ghost users bug:
https://tracker.phpbb.com/browse/PHPBB3-15060

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: URL with post number (limits of the feature)

Post by A_Jelly_Doughnut » Mon Oct 30, 2017 2:52 am

Vinny wrote:
Mon Oct 23, 2017 6:10 am
viewtopic.php?f=126&t=52441#p304646 (forum id+topic id+post id)
viewtopic.php?t=52441#p304646 (topic id+post id)
viewtopic.php?p=304646#p304646 (post id)

these 3 links take you to the same post, in addition "t+p numbers" already exist.
Links 1 and 2 only take you to p304646 if it is on page 1 of the topic. Link 3 figures out which page it is on and will display the post, if it still exists.
A_Jelly_Doughnut

Post Reply