BBcodes

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
david63 Online
Registered User
Posts: 215
Joined: Mon Feb 07, 2005 7:23 am
Location: Lancashire, UK

BBcodes

Post by david63 » Tue Jun 27, 2017 5:54 am

Should the current set of hard-coded BBcodes be moved from being hard-coded to being pre-installed options?

There seems to be a number of requests to modify/remove these codes which currently is not possible without changing core code, but having them as options would give this added flexibility.
David
Remember: You only know what you know -
and you do not know what you do not know!

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 126
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: BBcodes

Post by Vinny » Tue Jun 27, 2017 9:24 am

+1

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: BBcodes

Post by Louis7777 » Tue Jun 27, 2017 1:21 pm

+1

Make them all pre-installed, editable / custom BBCodes.

However, what about img and url ? Don't they have some unique features that cannot be simply created via a custom BBCode? And color should be tied to a color picker (although some data attribute or id will suffice I guess).

P.S.: Remove flash ?

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: BBcodes

Post by brunoais » Tue Jun 27, 2017 1:37 pm

I agree with this. I even tried to do that with the WYSIWYG editor. But the current quote tag is too hard to make it work right. So I'm waiting for a solution.
Tbh, tags like img and url are "child's play" compared to the quote tag

User avatar
david63 Online
Registered User
Posts: 215
Joined: Mon Feb 07, 2005 7:23 am
Location: Lancashire, UK

Re: BBcodes

Post by david63 » Tue Jun 27, 2017 2:33 pm

If quote is too difficult to remove from the code, and I can appreciate that it could be, then leave that hard coded as I suspect that virtually all boards use that feature anyway.
David
Remember: You only know what you know -
and you do not know what you do not know!

User avatar
3Di
Registered User
Posts: 694
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: BBcodes

Post by 3Di » Tue Jun 27, 2017 3:57 pm

Louis7777 wrote:
Tue Jun 27, 2017 1:21 pm
Make them all pre-installed, editable / custom BBCodes.
Too much of cons I guess.
Louis7777 wrote:
Tue Jun 27, 2017 1:21 pm
However, what about img and url ? Don't they have some unique features that cannot be simply created via a custom BBCode?
Those two should IMO stay there, quote as well.
Louis7777 wrote:
Tue Jun 27, 2017 1:21 pm
And color should be tied to a color picker (although some data attribute or id will suffice I guess).
Actually is http://prntscr.com/fosygh .. or am I mssing something?
Louis7777 wrote:
Tue Jun 27, 2017 1:21 pm
P.S.: Remove flash ?
Yes, Please.
Want to compensate me for my interest? Don't ask me, just do it
I'm available for custom phpBB jobs, you can PM me the details.
New: my Live Board, Extensions and Tools for phpBB - Men at works.

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: BBcodes

Post by Louis7777 » Tue Jun 27, 2017 4:40 pm

3Di wrote:
Tue Jun 27, 2017 3:57 pm
Actually is http://prntscr.com/fosygh .. or am I mssing something?
It currently is, because it is hard-coded.

User avatar
JoshyPHP
Registered User
Posts: 349
Joined: Fri Jul 08, 2011 9:43 pm

Re: BBcodes

Post by JoshyPHP » Tue Jun 27, 2017 11:36 pm

The BBCode definitions are stored in the PHP sources but they are no different from custom BBCodes and it would be possible to store them in the database to make them editable.

If anyone wants to do it, here are the relevant sections: (you'd need to create a migration too)
Maybe it could be split into two subtasks:
  1. Remove the part in the ACP that prevents overwriting the default BBCodes.
    → Allows expert admins to overwrite the defaults.
  2. Add the default BBCodes to the list shown in the ACP.
    → Lets all admins delete the default BBCodes and then complain that they don't work anymore. :sarcasm:

User avatar
3Di
Registered User
Posts: 694
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: BBcodes

Post by 3Di » Wed Jun 28, 2017 3:26 am

Too much of Cons against Pros IMO.

And the sarcasm is appropriated, I wouldn't imagine how many support requests will be created and how many disappointed not-expert Admins who are blaming people here and there etc.. Nah.

It is a tricky situation, not easy to solve. If this is the goal.
BBcodes are a foundation very difficult to break-thru.
Want to compensate me for my interest? Don't ask me, just do it
I'm available for custom phpBB jobs, you can PM me the details.
New: my Live Board, Extensions and Tools for phpBB - Men at works.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 789
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: BBcodes

Post by hanakin » Thu Jun 29, 2017 12:55 am

they should not be db options in the way the custom ones are. the way the standard ones should be handled is 100% from the bbcodes.html file as this allows for the most flexibility for customization for the style authors. Currently it is not handled this way by default

Post Reply