EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by Dragosvr92 » Thu Nov 24, 2016 12:27 am

If you add anything in the overall_footer_content_after EVENT, it gets overlayed on the Jumpbox in the user profile.
Example:
Create the overall_footer_content_after.html event.

Add:

Code: Select all

<div style="background-color:#553D3C;padding: 4px;">Testing</div>
The jumpbox code needs to be better placed. Not sure how though atm.
Capture.PNG
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by hanakin » Thu Nov 24, 2016 1:09 am

The name of the event is wrong for where its located for one as its placed at the end of the body not the footer

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by Dragosvr92 » Thu Nov 24, 2016 2:47 pm

I fixed it by using the if statements to hide from ucp, adm, etc pages. But It should be fixed though.
The jumpbox needs to be added after the user profile wrapper. Not before the navbar.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by hanakin » Thu Nov 24, 2016 11:31 pm

@Dragosvr92 can you pls create a ticket and submit a pr for it?

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by Dragosvr92 » Sat Nov 26, 2016 12:43 am

I can create a ticket, but i am unsure on how to fix it. I only found a way around it, hiding the content on those pages.
https://tracker.phpbb.com/browse/PHPBB3-14881
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by VSE » Sat Nov 26, 2016 9:41 am

The event is perfectly fine...and correct!

There are floated elements in the style. Your template event listener needs to clear floats. Just add class="clear" to your div.
Has an irascible disposition.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by Dragosvr92 » Sun Nov 27, 2016 6:55 pm

Adding the clear class breaks the existing layout of your div and you need to add extra css code to get it back to normal.

People that add content in the event usually want it to show in the main page footer, less on these pages: Memberlist, The team, Viewing Profiles, Vieving Groups.

Seems odd/unusual that you need to do extensive tweaking because the Jumpbox is badly placed and overlaps on plain new contents.
But thats just me.......
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by VSE » Sun Nov 27, 2016 7:55 pm

Dragosvr92 wrote:
Sun Nov 27, 2016 6:55 pm
Adding the clear class breaks the existing layout of your div and you need to add extra css code to get it back to normal.

People that add content in the event usually want it to show in the main page footer, less on these pages: Memberlist, The team, Viewing Profiles, Vieving Groups.

Seems odd/unusual that you need to do extensive tweaking because the Jumpbox is badly placed and overlaps on plain new contents.
But thats just me.......
Then use a clearing div before your content to break the floats. Works just fine:
<div class="clear"></div>
Screen Shot 2016-11-27 at 11.52.48 AM.png
It's not odd/unusual to have to make your template event listener work. You are injecting new code into a style. You can't assume your own code will just work plug-n-play. You have to make your code work within the style, at the injection point. The template events are, afterall, still what you should consider part of the style and are thus required to do whatever needed to make them work with the style (and that applies to every style).
Has an irascible disposition.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by hanakin » Mon Nov 28, 2016 4:34 pm

the code is broken as well the jumpbox should be contained in the same div as the return link but its not. Its not consistently placed the same way throughout the theme. It all needs a wrapping div around it and separated out into its own partial similar to the action-bar

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

Post by Dragosvr92 » Thu Dec 01, 2016 10:26 pm

Thank you for the pullrequest Hanakin. :)
*Sticking my tongue at the VSE grumpycat*
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply