RFC - Poll system

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
javiexin
Registered User
Posts: 90
Joined: Thu Dec 22, 2011 10:04 am

RFC - Poll system

Post by javiexin » Wed Nov 16, 2016 4:39 am

The current poll system in phpbb 3.1 and 3.2 is very límited, and the code is mostly 3.0 or even previous to that.

What I would like to propose is replacing this with a new rewrite, based on the same concepts as other rewritten parts of phpbb, such us avatars and profile fields (by the way, this one is NOT complete yet, please, recheck and approve my PRs on PFs ;)).

That is, creating a poll_manager object and a poll interface (with current functionality as default) that could be implementen and extended by extension developers. The current way to do this (through events that are not ideally placed, with code scattered throughout the phpbb core) is really cumbersome, and hacky.

I could volunteer to write such a module, ideally for some 3.2.x version. But it will be done when it is done :lol:, health and time permitting.

Thoughts anyone? Should I go for this?
Regards,
-javiexin

CHItA
Development Team
Development Team
Posts: 128
Joined: Thu Mar 12, 2015 1:43 pm
Location: Budapest, Hungary

Re: RFC - Poll system

Post by CHItA » Wed Nov 16, 2016 6:05 pm

Sure, if you want to refactor some legacy part, feel free to do that. I would say unless you change something in behavior there isn't really a need to post an RFC (of course if you looking for feedback it is probably the way to go).

I would also like to note that it would be great if you could keep the current events for backward compatibility. Also 3.2 is feature frozen, so the version must be 3.3 (or whenever you're done with it).

Post Reply