[RFC][PHPBB3-14596] 3.1.x - Installation denied if PHP >=7

[Nicofuma]

You always have a carbon copy of phpBB. Always. The only difference could be with the default branch but it doesn't matter because it doesn't change the content of the git repository at all and it van be changed at any time

[DavidIQ]

The issue it was IMHO about the phpBB's repo being sat to the 3.1.x branch as per default but we need to fork the MASTER branch.. anyway....

Not at all, no. When you fork a repo you're forking the entire repo, not just an individual branch. It would be up to you to switch branches locally to the right one after cloning finishes (i.e. git checkout 3.1.x) to then create your local branch for your proposed changes. You seem to be on the right track now though.

[3Di]

You always have a carbon copy of phpBB. Always. The only difference could be with the default branch but it doesn't matter because it doesn't change the content of the git repository at all and it van be changed at any time

I do not know why but during my experiments (4 days) I have found that (as I above stated) only if you fork the phpbb's repo (on github, I mean I am forking the phpbb one from github in order to have a fork into my github's account) after you sat it to be into the MASTER branch gave to me the install folder like it should have been (into my PC, so here I am CLONING my phpbb fork into my PC) .. but I could be wrong and in any case - as for now - I am not so really willing to step back and redo all of what I did to confirm again this .. you know..

Thanks Nicofuma, I really appreciate.

The issue it was IMHO about the phpBB's repo being sat to the 3.1.x branch as per default but we need to fork the MASTER branch.. anyway....

Not at all, no. When you fork a repo you're forking the entire repo, not just an individual branch. It would be up to you to switch branches locally to the right one after cloning finishes (i.e. git checkout 3.1.x) to then create your local branch for your proposed changes.

Sure thing.
I believe that's should be the intended behaviour but as I above explained I faced some issues in order to have also the install folder as it should have been..
The logic though positively plays on your side guys, I know.. :

You seem to be on the right track now though.

To give up has never been into my plans.

I thank one more this great Community for all of the patience that demonstrate to us noobs, for the sake of a great project and the spirit of it.

I am always open to discuss anything I posted, regards.