prosilver 3.2.0 - icon styles - semi-hardcoded colour

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
nachtelb
Registered User
Posts: 30
Joined: Sun Feb 19, 2006 1:55 pm
Location: Germany
Contact:

prosilver 3.2.0 - icon styles - semi-hardcoded colour

Post by nachtelb »

Hello,
in the new css-files i found this code:

Code: Select all

/* Icon styles
---------------------------------------- */
.icon.icon-blue, a:hover .icon.icon-blue {
	color: #196db5;
}

.icon.icon-green, a:hover .icon.icon-green{
	color: #1b9A1B;
}

.icon.icon-red, a:hover .icon.icon-red{
	color: #BC2A4D;
}

.icon.icon-orange, a:hover .icon.icon-orange{
	color: #FF6600;
}

.icon.icon-bluegray, a:hover .icon.icon-bluegray{
	color: #536482;
}

.icon.icon-gray, a:hover .icon.icon-gray{
	color: #777777;
}

.icon.icon-lightgray, a:hover .icon.icon-lightgray{
	color: #999999;
}

.icon.icon-black, a:hover .icon.icon-black{
	color: #333333;
}

.alert_close .icon:before {
	background-color: #FFFFFF;
}
1. The naming is irritating, because i dont know where they will be used.
2. I only want to change the css-files to change the colours. This is the difference between Theme and Template in my eyes. If i'am right, i would have to change the template-files to change the hardcoded colour-name. At the moment "icon-red" is coloured orange in my style. A little bit freaky, isnt it?

Wouldnt it be better to give other names to the icon-styles instead of colours?
icon-red.jpg

leschek
Registered User
Posts: 163
Joined: Tue Aug 28, 2012 1:30 pm

Re: prosilver 3.2.0 - icon styles - semi-hardcoded colour

Post by leschek »

I thought the same when I changed the color of .icon.icon-black, a:hover .icon.icon-black to color: #009FF4; (blue).

Post Reply