Change title of main topic and title of response

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
hrx

Change title of main topic and title of response

Post by hrx » Mon Dec 14, 2015 1:49 pm

Hello,

Currently in phpBB doesn't have a possibility of the change of name of the main topic along with all replies "Re:". I wrote a request whether somebody could to create the extension, thanks to which it would be possible to change it, unfortunately nobody answered. I decide to write the suggestion in Area51, if could you at one time release such a function? In my opinion it's needed option for the moderation.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1780
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Change title of main topic and title of response

Post by DavidIQ » Mon Dec 14, 2015 11:58 pm

Sounds like an extension to me.
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Change title of main topic and title of response

Post by Dragosvr92 » Tue Dec 15, 2015 12:27 am

That will be a bit difficult as each post has its own subject title. The same topic title gets copied over and over again.
For which i made this topic. viewtopic.php?f=81&t=45797
If we remove all the static post title from being copied repeatedly in each post, and just use the topictitle to repeat it there(if thats really needed), what you seek would be done without any extension.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Change title of main topic and title of response

Post by Pony99CA » Tue Dec 15, 2015 2:30 am

It's VERY simple, I believe. If the title of the topic post doesn't equal the old topic title, just update all occurrences in the posts table where the title equals "RE: [old topic title]" to "RE: [new topic title]". You can probably do it myPHPAdmin. (NOTE: I haven't looked at the phpBB database for a while, so it could be a bit more complicated. :D)

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Change title of main topic and title of response

Post by VSE » Tue Dec 15, 2015 3:11 am

Pony99CA wrote:
Tue Dec 15, 2015 2:30 am
It's VERY simple, I believe. If the title of the topic post doesn't equal the old topic title, just update all occurrences in the posts table where the title equals "RE: [old topic title]" to "RE: [new topic title]". You can probably do it myPHPAdmin. (NOTE: I haven't looked at the phpBB database for a while, so it could be a bit more complicated. :D)

Steve
Well, almost... Not all occurrences in the posts table. It's very possible that there could be other topics with the exact same title. So you'd also want to make sure it's only posts who belong to the actual topic id being edited. ;)

Hmm, I may look into this one.
Has an irascible disposition.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Change title of main topic and title of response

Post by Dragosvr92 » Tue Dec 15, 2015 7:45 pm

You could do that in phpmyadmin. And specifying the topic id of the data you want to change should be also possible.
I guess it would be something similar to this?

Code: Select all

UPDATE phpbb_posts SET post_subject = 'Re: NEW TITLE' WHERE post_subject = 'Re: OLD TITLE' AND topic_id="48706";
But using the same title string and display it in all entries would be better than keeping to copy it over and over.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
pierredu
Registered User
Posts: 38
Joined: Sat Dec 05, 2015 7:21 am

Re: Change title of main topic and title of response

Post by pierredu » Tue Dec 15, 2015 8:01 pm

VSE wrote:
Tue Dec 15, 2015 3:11 am
Hmm, I may look into this one
If you do that, could you provide an option to have the 'Re: ' prefix or not?
This is the ugliest thing I ever saw (albeit it is the norm in english or even in US-english).

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Change title of main topic and title of response

Post by VSE » Tue Dec 15, 2015 11:27 pm

Has an irascible disposition.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Change title of main topic and title of response

Post by Dragosvr92 » Wed Dec 16, 2015 4:29 pm

pierredu wrote:
Tue Dec 15, 2015 8:01 pm
If you do that, could you provide an option to have the 'Re: ' prefix or not?
This is the ugliest thing I ever saw (albeit it is the norm in english or even in US-english).
To remove the prefix :
Find this part in the vse/smartsubjects/event/main_listener.php:

Code: Select all

// Re: is actually hardcoded within phpBB ¯\_(ツ)_/¯
$old_subject = 'Re: ' . $event['data']['topic_title'];
$new_subject = 'Re: ' . $event['post_data']['post_subject'];
Replace the last line with this:

Code: Select all

$new_subject = $event['post_data']['post_subject'];
or this

Code: Select all

$new_subject = '' . $event['post_data']['post_subject'];
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Change title of main topic and title of response

Post by VSE » Thu Dec 17, 2015 5:14 am

^^ Don't do what Dragosvr92 mentions there unless you want to make a right mess of your board!!! 'Re: ' is stored in the database. Doing what he recommends will make a messy situation where most titles will still have it, and some (only the one's edited) won't. If you ever decide to remove the extension...you're sh@t outta luck! You're stuck with some titles having it and some not. Very destructive and irreversible!!

Disclaimer: Editing/hacking extensions is never condoned or recommended, and grounds for termination of support IMO.

As per removing Re:... Not gonna happen! For one thing, I personally agree with having Re:, considering every reply is in regards or reference to the primary post...or some post above...same thing you see in emails, for example.

I have already looked into what it would take to remove it using the extension I made, and it's simply not possible from an extension in a non-destructive way. For one thing, post titles are shown everywhere: viewtopic, topic review, MCP, UCP, admin logs, feeds, forum index, search results, notifications, and many more places! It's unrealistic to try to have an extension remove "Re:" from every possible location where it can be shown, and that's not even taking into account other extensions that may show them.

So that leaves only the destructive option, to wipe them from the database. This of course is unacceptable as it has no safe way of reverting back if you decide to remove the extension. In fact, no extension should ever make such decisive changes to the exisiting data on a forum...that's no longer extending phpBB, that's outright hacking it!

So my initial assessment of adding an option to remove "Re:" from titles with the extension I wrote is - not gonna happen.

I would instead petition for the phpBB core to consider removing them, if they truly do serve no purpose and are deemed an outdated concept. This extension would easily be able to be updated to continue doing its normal task of rewriting reply subjects and leave the omission or comission of "Re" prefixing up to the core.
Has an irascible disposition.

Post Reply