Resize large images in signatures to 300px

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Resize large images in signatures to 300px

Post by Dragosvr92 » Thu Dec 03, 2015 9:52 am

People can use one or more very large images into their signatures. These are resized to display in the available space, but they shouldnt as they can take a lot of space and add extra scrolling just to see someone's exaggeratedly large sig image.


I made screenshots with before and after the use of a large image, and resizing it to 333px. Any opinions?
Attachments
As it is now.jpg
As it is now with max-width:100%;
As it should be.png
As it should be with max-width:333px;
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: Resize large images in signatures to 300px

Post by VSE » Thu Dec 03, 2015 5:04 pm

Extensions
Has an irascible disposition.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Resize large images in signatures to 300px

Post by Pony99CA » Fri Dec 04, 2015 2:43 am

Why not just use the Maximum signature image width and Maximum signature image height settings? I presume that it prevents adding large signatures, but if it scales the image to fit the space, I'm not sure how excessive scrolling occurs (I can see why page load times will be longer).

Maybe I'm missing something, though.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Resize large images in signatures to 300px

Post by Dragosvr92 » Fri Dec 04, 2015 5:00 am

I dont understand why terribly simple solutions should be added into extensions that could enhance the user experience by reducing pageload speed and the hassle to scroll around long-nonsense images. It is just one line of css. It makes no sense having a large image on fullsize in each signature.
It takes too much space. The signature should be something short that is somewhat meaningful/relevant to the user who has it....

Pony99CA, I didnt know of those settings, where can they be found?
I believe they just detect the image size and denies you submit the image. Having the user to adjust it locally to the allowed sizes.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: Resize large images in signatures to 300px

Post by RMcGirr83 » Fri Dec 04, 2015 10:40 am

Dragosvr92 wrote:
Fri Dec 04, 2015 5:00 am
Pony99CA, I didnt know of those settings, where can they be found?
In the signature settings of the ACP.
Do not hire Christian Bullock he won't finish the job and will keep your money

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Resize large images in signatures to 300px

Post by Dragosvr92 » Fri Dec 04, 2015 10:47 am

RMcGirr83 wrote:
Fri Dec 04, 2015 10:40 am
Dragosvr92 wrote:
Fri Dec 04, 2015 5:00 am
Pony99CA, I didnt know of those settings, where can they be found?
In the signature settings of the ACP.
I see, thanks. But i see they just detect the image size and denies you submit the image. Having the user to adjust it locally to the allowed sizes.
What about resizing the image via css? Or do you think this would be better of as an extension and not a core feature?
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Ger
Registered User
Posts: 282
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: Resize large images in signatures to 300px

Post by Ger » Fri Dec 04, 2015 10:52 am

Resizing it using CSS will still result in all users downloading the entire image. If some people are crazy enough to use a 5MB photo as their signature, people browsing on their mobile phone won't be happy.
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Resize large images in signatures to 300px

Post by Pony99CA » Sat Dec 05, 2015 2:49 am

Ger wrote:
Fri Dec 04, 2015 10:52 am
Resizing it using CSS will still result in all users downloading the entire image. If some people are crazy enough to use a 5MB photo as their signature, people browsing on their mobile phone won't be happy.
Which is probably why violating the size constraint denies uploading the image instead of re-sizing it.

Now if the re-sizing could be done server-side to fit the constraints, that might be useful.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
DavidIQ Online
Customisations Team Leader
Customisations Team Leader
Posts: 1750
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Resize large images in signatures to 300px

Post by DavidIQ » Mon Dec 07, 2015 1:44 pm

Pony99CA wrote:
Sat Dec 05, 2015 2:49 am
Ger wrote:
Fri Dec 04, 2015 10:52 am
Resizing it using CSS will still result in all users downloading the entire image. If some people are crazy enough to use a 5MB photo as their signature, people browsing on their mobile phone won't be happy.
Which is probably why violating the size constraint denies uploading the image instead of re-sizing it.

Now if the re-sizing could be done server-side to fit the constraints, that might be useful.

Steve
:?: you can't upload files for signature use only...
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: Resize large images in signatures to 300px

Post by Dragosvr92 » Mon Dec 07, 2015 2:59 pm

DavidIQ wrote:
Mon Dec 07, 2015 1:44 pm
:?: you can't upload files for signature use only...
"Which is probably why violating the size constraint denies submitting the image instead of re-sizing it."
He made a mistake. Its not uploading but submitting/accepting to attach the image to the signature.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply