You also could send a PR yourself.mrgtb wrote:BUMP!
Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.
Smiley and Whos Onlike pop-up boxes are making styling difficult
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
Member of the phpBB Development-Team
No Support via PM
No Support via PM
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
their are alos more areas related to this than just the two referenced instances
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
Wasn't aware of that. What other areas get affected?hanakin wrote:their are alos more areas related to this than just the two referenced instances
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
Find Members and messaging
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
Ah right, never crossed my mind about that using a pop-up box in admin cp.
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
I don't really know a solution to the problem. I did mention "maybe" giving the pop-up boxes there own separate CSS style elements, so they can be styled separate instead of inheriting forum background e.t.c. But whether or not that's a good idea I've honestly no idea, just a thought off the top of my head.Nicofuma wrote:You also could send a PR yourself.mrgtb wrote:BUMP!
Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.
Others no doubt may come up with much better solutions.
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
Just a note - this happens with any pop-up boxes (like the "Find a member" pop-up in the ACP).
EDIT: Didn't see page 2.
EDIT: Didn't see page 2.
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
I read it and left a comment. See you made some more changes since. Last I looked it was only one file edit.
Can see you made some of the popup boxes so they are bigger on loading. Not tested the changes yet and will wait to see what happens first with RC3, if they accept it or go another route with it. I saw mentioned in comments about adding margin/padding back to pop-up boxes removed previously like phpBB 3.0 uses it. Would like to see that added back to the pop-up boxes as well. they don't look as good as in 3.0 without that margin/padding used.
Can see you made some of the popup boxes so they are bigger on loading. Not tested the changes yet and will wait to see what happens first with RC3, if they accept it or go another route with it. I saw mentioned in comments about adding margin/padding back to pop-up boxes removed previously like phpBB 3.0 uses it. Would like to see that added back to the pop-up boxes as well. they don't look as good as in 3.0 without that margin/padding used.
Re: Smiley and Whos Onlike pop-up boxes are making styling difficult
they are all consistent size of 750px no to prevent them from going to collapse mode as well as standardized all the h2 tags appearance.