Smiley and Whos Onlike pop-up boxes are making styling difficult

Post by **Nicofuma** » Mon Jul 28, 2014 10:24 pm

mrgtb wrote:BUMP!

Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.

You also could send a PR yourself.

Post by **hanakin** » Tue Jul 29, 2014 4:52 am

their are alos more areas related to this than just the two referenced instances

mrgtb · Post by **mrgtb** » Tue Jul 29, 2014 7:13 am

hanakin wrote:their are alos more areas related to this than just the two referenced instances

Wasn't aware of that. What other areas get affected?

Post by **hanakin** » Tue Jul 29, 2014 9:44 am

Find Members and messaging

mrgtb · Post by **mrgtb** » Tue Jul 29, 2014 2:00 pm

Ah right, never crossed my mind about that using a pop-up box in admin cp.

mrgtb · Post by **mrgtb** » Tue Jul 29, 2014 2:08 pm

Nicofuma wrote:
mrgtb wrote:BUMP!

Hmm, is this ever going to get fixed? I reported it in tracker 2 weeks ago and nobody assigned to it yet.
You also could send a PR yourself.

I don't really know a solution to the problem. I did mention "maybe" giving the pop-up boxes there own separate CSS style elements, so they can be styled separate instead of inheriting forum background e.t.c. But whether or not that's a good idea I've honestly no idea, just a thought off the top of my head.

Others no doubt may come up with much better solutions.

tbackoff · Post by **tbackoff** » Wed Jul 30, 2014 3:18 am

Just a note - this happens with any pop-up boxes (like the "Find a member" pop-up in the ACP).

EDIT: Didn't see page 2.

Post by **hanakin** » Wed Jul 30, 2014 3:50 pm

PR: https://github.com/phpbb/phpbb/pull/2783

mrgtb · Post by **mrgtb** » Wed Jul 30, 2014 5:15 pm

I read it and left a comment. See you made some more changes since. Last I looked it was only one file edit.

Can see you made some of the popup boxes so they are bigger on loading. Not tested the changes yet and will wait to see what happens first with RC3, if they accept it or go another route with it. I saw mentioned in comments about adding margin/padding back to pop-up boxes removed previously like phpBB 3.0 uses it. Would like to see that added back to the pop-up boxes as well. they don't look as good as in 3.0 without that margin/padding used.

Post by **hanakin** » Thu Jul 31, 2014 6:51 am

they are all consistent size of 750px no to prevent them from going to collapse mode as well as standardized all the h2 tags appearance.

Screenshot 2014-07-31 08.43.20.png: (23.88 KiB) Downloaded 372 times

Screenshot 2014-07-31 08.44.19.png: (16.81 KiB) Downloaded 372 times

Screenshot 2014-07-31 08.47.38.png: (45.84 KiB) Downloaded 372 times

Development Discussion Board

Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult

Re: Smiley and Whos Onlike pop-up boxes are making styling difficult