Integration question about globals

[omniError]

Hello, I'm taking the 3.1 RC for a spin and planning an integration with an existing CMS. First let me say I appreciate the new events dispatcher a lot.

My question is about super globals. For reasons I would rather not rehash, I need them on. I see that the constructor for the \phpbb\request class has a second parameter which controls this. The class also has an enable_super_globals() function. What would be the most correct way to do this without editing any core files?

Thanks.

[MattF]

It looks like you can just call $request->enable_super_globals();

https://github.com/phpbb/phpbb/blob/dev ... hp#L71-L74

[Nicofuma]

it could work if in your extension you override the request service like this: (but i'm not sure^^)

Code: Select all

    request:
        class: phpbb\request\request
        arguments:
            - null
            - false

EDIT: but it could be better to call enable_super_globals

[omniError]

Nicofuma's approach worked, although I don't know if that has any other consequences (like passing null for the first parameter). Would it?
I got tripped up a bit since I didn't know about clearing the cache after changing that file.

[Nicofuma]

indeed, when you change the configuration of the container (services.yml) you need to purge the cache or to disable/re-enable your extension.

About the null parameter it will not change anything the core use: (if i expand the default parameters)

Code: Select all

    request:
        class: phpbb\request\request
        arguments:
            - null
            - true

[bantu]

The class also has an enable_super_globals() function. What would be the most correct way to do this without editing any core files?

Calling that method is the intended way to get back super globals.