[Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Pony99CA » Thu Oct 08, 2015 1:27 am

DavidIQ wrote:
Wed Oct 07, 2015 9:00 pm
I'm actually seeing the same missing icons problem on my work machine (IE11) but I think it's some policy they've implemented here on the browser. The site looks fine on Chrome on the same machine and looks fine in IE11 on other non-work machines, although it looks fine in Edge on my work laptop. Fiddler doesn't show anything out of the ordinary that can help to identify the issue and the DOM explorer (F12 tools) doesn't show anything out of the ordinary.
It could be a policy, I suppose. We recently got Chrome here and it does show the icons.

It's possible that it's also my old PC. I can't get to MSDN from here in IE, but I can get there in Chrome. Some System tech said that it could be because my machine is so old that it's not getting patches that it should get.

I'm supposed to get a new PC "soon", so we'll see if it fixes things. I guess that I'll just use Chrome when I visit here from now on. :D

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
kinerity
Registered User
Posts: 22
Joined: Mon Sep 01, 2014 10:54 pm

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by kinerity » Fri Oct 09, 2015 1:42 pm

hanakin wrote:
Sun Oct 04, 2015 3:15 am
as for the home thing ill look into it, but it might be area51 specific
I don't think so, it's in the "master" branch... navbar_header.html#L180-L184

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Sun Oct 11, 2015 10:14 am

DavidIQ wrote:
Sun Oct 04, 2015 12:20 pm
Viewing the topic list on my iPad in portrait mode and with unread replies causes the new replies icon to be on one line and the topic title to be on another. Not sure if that's a result of this ticket or another or if it's already been fixed but looks pretty bad.
not actually an issue caused by anything in 3.2 it is there in 3.1 and is caused by horrible design/layout of prosilver so its not going to be a very clean fix, but ill look into it.

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Arty » Sun Oct 11, 2015 1:33 pm

hanakin wrote:
Sun Oct 11, 2015 10:14 am
not actually an issue caused by anything in 3.2 it is there in 3.1 and is caused by horrible design/layout of prosilver so its not going to be a very clean fix, but ill look into it.
No, its not in 3.1 and it is caused by changes in 3.2. More specifically by addition of display:inline-block to all links.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Sun Oct 11, 2015 2:27 pm

both facts are true. The icon issue is related to 3.2 but the overall poor look on the tablet of the whole DT section is not which is what I took away from his post.

User avatar
kinerity
Registered User
Posts: 22
Joined: Mon Sep 01, 2014 10:54 pm

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by kinerity » Wed Oct 14, 2015 3:46 am

hanakin wrote:
Sun Oct 11, 2015 2:27 pm
both facts are true. The icon issue is related to 3.2 but the overall poor look on the tablet of the whole DT section is not which is what I took away from his post.
Who are you referencing here? If it was me, first - I'm female, but that's beside the point. Second, I was specifically talking about the icon issue. It is NOT present in 3.1, but is present in 3.2. I'm not sure why you're saying it won't be an "easy fix" as I provided one here (perfectly acceptable by the current coding standards). ;) Am I missing something? I know I don't post here often, but I do follow development as much as I can.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Wed Oct 14, 2015 4:37 am

again I miss understood what davidIQ was referring too taking it to mean the overall rendering of the topic row on tablets which if you look at the screenshot looks fugly. The icon is not hard to fix the responsiveness of the overall topic row at the ipad size was. Either way all have been addressed in this pr: https://github.com/phpbb/phpbb/pull/3960

As for your issue it was already megred just not applied to area51 yet https://github.com/phpbb/phpbb/pull/3962

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Arty » Wed Oct 14, 2015 7:58 am

No, you got that wrong. Issue is latest post icon (red icon on left of topic title) is moved to its own line. Pagination is fine.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by DavidIQ » Wed Oct 14, 2015 10:21 am

Yeah sorry. Probably should have cropped down the image to the problem area...
Image

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Nicofuma » Wed Oct 14, 2015 11:13 am

By the way, tbh I think that having the pagination on a new line like in hanakin's proposal is cleaner
Member of the phpBB Development-Team
No Support via PM

Post Reply