[Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Pony99CA » Sat Oct 03, 2015 1:05 am

callumacrae wrote:
Fri Oct 02, 2015 11:34 am
Pony, are you using an adblocker? Some of the more overzealous ones block icon fonts (have I mentioned yet that they suck?)
Not on this PC. I used to have problems with graphics showing up on phpBB.com (like avatars), but that problem went away a while ago. The proxy here does block some domains, though, so if you tell me the URL of the server, I can check that.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
kinerity
Registered User
Posts: 22
Joined: Mon Sep 01, 2014 10:54 pm

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by kinerity » Sat Oct 03, 2015 5:03 am

Is it really necessary to have the "home" icon appear twice in the breadcrumbs? It just looks cheap.

Looking at the code, we could easily change

Code: Select all

<span class="crumb" {$MICRODATA}><a href="{U_INDEX}" accesskey="h" data-navbar-reference="index"><i class="icon fa-home fa-fw"></i><span>{L_INDEX}</span></a></span>
to

Code: Select all

<span class="crumb" {$MICRODATA}><a href="{U_INDEX}" accesskey="h" data-navbar-reference="index"><!-- IF not U_SITE_HOME --><i class="icon fa-home fa-fw"></i><!-- ENDIF --><span>{L_INDEX}</span></a></span>
Screenshot of the effect:

breadcrumbs.png
breadcrumbs.png (2.55 KiB) Viewed 16572 times

EDIT: Adding attachments is somewhat broken. If you add an attachment, you have to refresh the page for the box to appear where you can "place inline" or "delete file". Not sure if this needs to be a bug report or not as I know Area51 has some quirks.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Sun Oct 04, 2015 3:11 am

Pony99CA wrote:
Thu Oct 01, 2015 2:01 am
I'm still seeing this problem on my work system using IE 10. Are the icons being delivered through a CDN or something?

Steve
CDN with fallback do an inspection of the source and see which its attempting to load

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Sun Oct 04, 2015 3:15 am

kinerity wrote:
Sat Oct 03, 2015 5:03 am
Is it really necessary to have the "home" icon appear twice in the breadcrumbs? It just looks cheap.

Looking at the code, we could easily change

Code: Select all

<span class="crumb" {$MICRODATA}><a href="{U_INDEX}" accesskey="h" data-navbar-reference="index"><i class="icon fa-home fa-fw"></i><span>{L_INDEX}</span></a></span>
to

Code: Select all

<span class="crumb" {$MICRODATA}><a href="{U_INDEX}" accesskey="h" data-navbar-reference="index"><!-- IF not U_SITE_HOME --><i class="icon fa-home fa-fw"></i><!-- ENDIF --><span>{L_INDEX}</span></a></span>
Screenshot of the effect:

breadcrumbs.png

EDIT: Adding attachments is somewhat broken. If you add an attachment, you have to refresh the page for the box to appear where you can "place inline" or "delete file". Not sure if this needs to be a bug report or not as I know Area51 has some quirks.
already patched the attachments needs pushed to area51, as for the home thing ill look into it, but it might be area51 specific

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by DavidIQ » Sun Oct 04, 2015 12:20 pm

Viewing the topic list on my iPad in portrait mode and with unread replies causes the new replies icon to be on one line and the topic title to be on another. Not sure if that's a result of this ticket or another or if it's already been fixed but looks pretty bad.
Image

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by hanakin » Mon Oct 05, 2015 3:09 am

David provided screenshot and I'll look into it when I get back

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by DavidIQ » Mon Oct 05, 2015 10:38 am

Here you go.
Attachments
image.png
Landscape (looks ok)
image.png
Portrait (doesn't look ok)
Image

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Arty » Mon Oct 05, 2015 2:10 pm

It is caused by addition of this line: https://github.com/phpbb/phpbb/blob/mas ... ks.css#L11

Browsers wrap inline and inline-block elements differently. When there are 2 inline elements in a row and whole text doesn't fit available width, browsers display split text like both elements were part of same element. When element its trying to wrap has display:inline-block, it is moved to its own line like block element.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by Pony99CA » Wed Oct 07, 2015 1:48 am

DavidIQ wrote:
Sun Oct 04, 2015 12:20 pm
Viewing the topic list on my iPad in portrait mode and with unread replies causes the new replies icon to be on one line and the topic title to be on another. Not sure if that's a result of this ticket or another or if it's already been fixed but looks pretty bad.
I get that same behavior on my desktop PC in IE 10. And, as I don't see the icon, I have to mouse around a bit to find the hot spot. :evil:

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

Post by DavidIQ » Wed Oct 07, 2015 9:00 pm

I'm actually seeing the same missing icons problem on my work machine (IE11) but I think it's some policy they've implemented here on the browser. The site looks fine on Chrome on the same machine and looks fine in IE11 on other non-work machines, although it looks fine in Edge on my work laptop. Fiddler doesn't show anything out of the ordinary that can help to identify the issue and the DOM explorer (F12 tools) doesn't show anything out of the ordinary.
Image

Post Reply