Improve the "Attachment settings" in ACP

[M.Gaetan89]

Hello,

I just installed phpBB3.1-b2 and started to configure it and now I have a couple of suggestions for the "Attachment settings" in the ACP.
I have a couple of small suggestions, and if they are fine for I, I can create the tickets and PRs.

First, it would be nice to support bigger file size than Mib in the select menus, next to the max size fields. I think that at least "Total attachment quota" could use the Gib file size.
Second, why doesn't the "Minimum thumbnail file size" setting have the same select menu for the size ? The default value could then be "12 Kb" instead of "12000 Bytes". This is also true in "Avatar settings", for the "Maximum avatar file size" setting.

What do you think about these small improvments?

Gaëtan

[DavidIQ]

For one of my sites I use shared hosting, which is cheap and reliable, and I get all of 1 GB of server space. Your "Total attachment quota" suggestion wouldn't work for that case and the many other admins in the same situation.

[M.Gaetan89]

I am just suggesting to add the "Gb" option in the dropdown list. The admin would still be able to choose b, kb, or mb the same as before

[bantu]

Sure, these fields should also use the usual framework for generating filesize dropdowns. Feel free to create a ticket and fix it.

[M.Gaetan89]

I created the issue: PHPBB-12340 (I almost got issue 12345 ).
I will submit a PR as soon as I can.

[keith10456]

@ M.Gaetan89 - Good idea... And thanks for implementing

[PayBas]

Agreed. I don't think many boards would use it, but with the costs of hosting going down and down... it might be good, if nothing else... just to be future-proof.