Posts from foe list is being shown

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Posts from foe list is being shown

Post by Danielx64 » Mon Dec 16, 2013 11:29 am

Rant coming up: I am on my phone and at the main forum, I dont see posts from people in my foe list unless I click on the link to show it. Here at area51 the posts from people in my foe list are being displayed. Are css being used to hide those posts? If so, any chance of having that changed back?

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Posts from foe list is being shown

Post by nickvergessen » Mon Dec 16, 2013 11:32 am

I think this might have been broken by the responsive layout stuff?

Edit: just tested and works okay for me.
Member of the Development-TeamNo Support via PM

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Posts from foe list is being shown

Post by Danielx64 » Mon Dec 16, 2013 11:38 am

Get no idea at all what's going on but yeah I wasn't too happy (yes I did go and get a drink). I got javascript and css turned off as it kills it (slow and can lock it up).

User avatar
Mess Online
Registered User
Posts: 197
Joined: Wed Jun 13, 2012 10:14 am

Re: Posts from foe list is being shown

Post by Mess » Tue Dec 17, 2013 9:50 am

I can't reproduce this. Posts from the person on my foe list are hidden on my smartphone, and on PC.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Posts from foe list is being shown

Post by Danielx64 » Tue Dec 17, 2013 11:37 am

Is css and javascript turned off? That's the key here

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Posts from foe list is being shown

Post by nickvergessen » Tue Dec 17, 2013 11:39 am

Well in 3.1 we always use JS and css to display hidden posts.
Of course posts are displayed then, if you disable them
Member of the Development-TeamNo Support via PM

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Posts from foe list is being shown

Post by Danielx64 » Tue Dec 17, 2013 11:44 am

So I take it that the behaviour has changed from 3.0?

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Posts from foe list is being shown

Post by nickvergessen » Tue Dec 17, 2013 11:46 am

Yes in 3.0 you needed to reload the page, when you actually want to read the hidden post.
In 3.1 we just display the hidden container after pressing the link, so no additional pageload is needed.

But from what I see currently, it should work as it did in 3.0, when JS is disabled.
Member of the Development-TeamNo Support via PM

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Posts from foe list is being shown

Post by Danielx64 » Tue Dec 17, 2013 11:50 am

Ok then, any chance of adding an option so that users got a choice? It going to be plain annoying for those who has javascript or css turned off on their phone.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Posts from foe list is being shown

Post by nickvergessen » Tue Dec 17, 2013 11:53 am

Sorry, but disabling CSS seems kind of hardcore to me, I don't think we will resolve this.

Code: Select all

<dl class="postprofile" id="profile{postrow.POST_ID}"<!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->>
is used and seems okay for me.

Adding additional user options for stuff like this will only clutter the UCP
Member of the Development-TeamNo Support via PM

Post Reply