[Template] Plans for mini post buttons?

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
..::Frans::..
Registered User
Posts: 27
Joined: Wed Mar 01, 2006 8:20 am

Re: [Template] Plans for mini post buttons?

Post by ..::Frans::.. »

Did the contact minis too, took some tweaking to get them right and one can ask if we still need the msn icon....but i think they also came out nice... Will finish everything this week and push the changes to github....

Image

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [Template] Plans for mini post buttons?

Post by VSE »

Why is "Quote" not all upper case, like EDIT? Should be, for consistency. Also, that exclamation mark isn't very clear.
Has an irascible disposition.

..::Frans::..
Registered User
Posts: 27
Joined: Wed Mar 01, 2006 8:20 am

Re: [Template] Plans for mini post buttons?

Post by ..::Frans::.. »

VSE+ wrote:Why is "Quote" not all upper case, like EDIT? Should be, for consistency. Also, that exclamation mark isn't very clear.
I agree with the exclamation mark, i will see if i can make that one a bit more robust...

As for the uppercase (or lowercase) texts, those are language variables. Now, i have been seeking for the reason the two weren't alike. That was my mistake, i used the language_vars L_EDIT and L_QUOTE. Quote exists, but EDIT doesn't.

I saw that there are variables created in common.php named BUTTON_EDIT and BUTTON_QUOTE. I will change the vars to those (btw, those aren't all uppercase)

;-)

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 935
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Template] Plans for mini post buttons?

Post by hanakin »

can you please post on git or something. Its easier to provide feed back based on code and previewing it...
Donations welcome via Paypal Image

..::Frans::..
Registered User
Posts: 27
Joined: Wed Mar 01, 2006 8:20 am

Re: [Template] Plans for mini post buttons?

Post by ..::Frans::.. »

see pull request #1934 ;-)

And i know, i haven't deleted all old image files...

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [Template] Plans for mini post buttons?

Post by VSE »

..::Frans::.. wrote:
VSE+ wrote:Why is "Quote" not all upper case, like EDIT? Should be, for consistency. Also, that exclamation mark isn't very clear.
I agree with the exclamation mark, i will see if i can make that one a bit more robust...

As for the uppercase (or lowercase) texts, those are language variables. Now, i have been seeking for the reason the two weren't alike. That was my mistake, i used the language_vars L_EDIT and L_QUOTE. Quote exists, but EDIT doesn't.

I saw that there are variables created in common.php named BUTTON_EDIT and BUTTON_QUOTE. I will change the vars to those (btw, those aren't all uppercase)

;-)
You can make them uppercase in your CSS using: text-transform:uppercase;
Has an irascible disposition.

..::Frans::..
Registered User
Posts: 27
Joined: Wed Mar 01, 2006 8:20 am

Re: [Template] Plans for mini post buttons?

Post by ..::Frans::.. »

Yes, i know....but thnx for the tip! ;-)


..::Frans::..
Registered User
Posts: 27
Joined: Wed Mar 01, 2006 8:20 am

Re: [Template] Plans for mini post buttons?

Post by ..::Frans::.. »

Thx Keith! ;-)

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 935
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [Template] Plans for mini post buttons?

Post by hanakin »

I think the font works if you are trying to closely match the size of the text on the post-icons however, I would argue that this is completely unnecessary. The reason the text is so small is that the entire thing was considered an icon and had to adhere to the size constraints of 16px put on icons with the theme.

I would rather have a consistant style between the post-icons and the topic action buttons using the same font for both. This would make for a slightly larger button than an icon but would enhance the UI consistency of the theme especially with the addition of the new tool menu.

As for the contact icons they are fine and the debate of keeping msn is left to its own RFC as if we do so should we not then add skype?
Donations welcome via Paypal Image

Post Reply