Remove Quote and Edit button when topic is lock
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
- Jessica.
- Registered User
- Posts: 144
- Joined: Wed Feb 09, 2011 8:17 pm
- Location: Pennsylvania, USA
- Contact:
Re: Remove Quote and Edit button when topic is lock
I agree with graying out the buttons.
Re: Remove Quote and Edit button when topic is lock
We can achive proper effect by replacing:
with
Code: Select all
<ul class="profile-icons">
Code: Select all
<ul class="profile-icons"<!-- IF S_IS_LOCKED --> style="opacity: 0.3;"<!-- ENDIF -->>
My mods:
Auto Backup [MODDB] | Reputation System [RC]
Auto Backup [MODDB] | Reputation System [RC]
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: Remove Quote and Edit button when topic is lock
A CSS class should be used
Re: Remove Quote and Edit button when topic is lock
Well, some style parts are not in css class For example
<!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->
My mods:
Auto Backup [MODDB] | Reputation System [RC]
Auto Backup [MODDB] | Reputation System [RC]
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: Remove Quote and Edit button when topic is lock
Just because some things currently are done one way doesn't mean we should do the the same thing for new code. Bad existing code is no excuse for bad new code.Pico88 wrote:Well, some style parts are not in css class For example<!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->
We also need to add a title attribute to explain that the topic locked that that operation is unavailable.
Would someone be willing to do a mockup and get screenshots of how this will look?
- A_Jelly_Doughnut
- Registered User
- Posts: 1780
- Joined: Wed Jun 04, 2003 4:23 pm
Re: Remove Quote and Edit button when topic is lock
Here is what it looks like with 50% opacity, in Fx 23.
Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.
EDIT: ticket for this: http://tracker.phpbb.com/browse/PHPBB3-11766
Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.
EDIT: ticket for this: http://tracker.phpbb.com/browse/PHPBB3-11766
- Attachments
-
- Faded-Edit.png
- (20.63 KiB) Downloaded 926 times
A_Jelly_Doughnut
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: Remove Quote and Edit button when topic is lock
It looks good, but it would useful to see that paired with the unlocked verson in the same attachment for comparison.A_Jelly_Doughnut wrote:Here is what it looks like with 50% opacity, in Fx 23.
If Moderators have to unlock the topic first, then their buttons should be grayed out, too. If Moderators can Post or Edit without unlocking, then they shouldn't be grayed.A_Jelly_Doughnut wrote:Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.
Oh, and this should probably also apply to the Delete (X) button, too.
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- A_Jelly_Doughnut
- Registered User
- Posts: 1780
- Joined: Wed Jun 04, 2003 4:23 pm
Re: Remove Quote and Edit button when topic is lock
It does apply to delete, as you can see in the screenshot (if not, this may not be the right effect!)
Moderators can click the greyed button and edit/delete/quote, given appropriate moderator permissions.
Branch is here if anyone wishes to comment: https://github.com/jellydoughnut/phpbb3 ... cket/11766
Moderators can click the greyed button and edit/delete/quote, given appropriate moderator permissions.
Branch is here if anyone wishes to comment: https://github.com/jellydoughnut/phpbb3 ... cket/11766
A_Jelly_Doughnut