Remove Quote and Edit button when topic is lock

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Jessica. » Wed Aug 14, 2013 3:25 pm

I agree with graying out the buttons.

User avatar
Pico88
Registered User
Posts: 73
Joined: Tue Apr 12, 2011 2:32 pm

Re: Remove Quote and Edit button when topic is lock

Post by Pico88 » Wed Aug 14, 2013 3:51 pm

We can achive proper effect by replacing:

Code: Select all

<ul class="profile-icons">
with

Code: Select all

<ul class="profile-icons"<!-- IF S_IS_LOCKED --> style="opacity: 0.3;"<!-- ENDIF -->>

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Remove Quote and Edit button when topic is lock

Post by EXreaction » Wed Aug 14, 2013 6:32 pm

A CSS class should be used ;)

User avatar
Pico88
Registered User
Posts: 73
Joined: Tue Apr 12, 2011 2:32 pm

Re: Remove Quote and Edit button when topic is lock

Post by Pico88 » Wed Aug 14, 2013 9:30 pm

Well, some style parts are not in css class ;) For example <!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Remove Quote and Edit button when topic is lock

Post by imkingdavid » Fri Aug 16, 2013 1:21 am

Pico88 wrote:Well, some style parts are not in css class ;) For example <!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->
Just because some things currently are done one way doesn't mean we should do the the same thing for new code. Bad existing code is no excuse for bad new code.

We also need to add a title attribute to explain that the topic locked that that operation is unavailable.

Would someone be willing to do a mockup and get screenshots of how this will look?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: Remove Quote and Edit button when topic is lock

Post by A_Jelly_Doughnut » Wed Sep 04, 2013 10:22 pm

Here is what it looks like with 50% opacity, in Fx 23.

Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.

EDIT: ticket for this: http://tracker.phpbb.com/browse/PHPBB3-11766
Attachments
Faded-Edit.png
(20.63 KiB) Downloaded 926 times
A_Jelly_Doughnut

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Pony99CA » Thu Sep 05, 2013 1:07 am

A_Jelly_Doughnut wrote:Here is what it looks like with 50% opacity, in Fx 23.
It looks good, but it would useful to see that paired with the unlocked verson in the same attachment for comparison.
A_Jelly_Doughnut wrote:Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.
If Moderators have to unlock the topic first, then their buttons should be grayed out, too. If Moderators can Post or Edit without unlocking, then they shouldn't be grayed.

Oh, and this should probably also apply to the Delete (X) button, too.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: Remove Quote and Edit button when topic is lock

Post by A_Jelly_Doughnut » Thu Sep 05, 2013 1:48 am

It does apply to delete, as you can see in the screenshot (if not, this may not be the right effect!)

Moderators can click the greyed button and edit/delete/quote, given appropriate moderator permissions.

Branch is here if anyone wishes to comment: https://github.com/jellydoughnut/phpbb3 ... cket/11766
A_Jelly_Doughnut

Post Reply