Graying them out is probably more consistent. I don't like popups but if the topic is locked my vote is for graying them out. I think Pony is right about usability. It's why a lot of online services still show you buttons to view your profile or shopping cart, but redirect you to a login page when you click on them.
IMO if the user is logged out they should be visible as well, and they should function the same as the reply button - by forwarding you to the login page.
Remove Quote and Edit button when topic is lock
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Re: Remove Quote and Edit button when topic is lock
Last edited by Frug on Thu Aug 08, 2013 6:48 pm, edited 1 time in total.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: Remove Quote and Edit button when topic is lock
We shouldn't display all those buttons as well for logged out users, just because they might be able to after logging in.
If we're trying to prevent confusion for users who can no longer edit something because another restriction is in place besides their permissions (e.g. the topic is locked), greying them out seems reasonable, but this shouldn't be a shortcut for every available option if users are not currently logged in.
If we're trying to prevent confusion for users who can no longer edit something because another restriction is in place besides their permissions (e.g. the topic is locked), greying them out seems reasonable, but this shouldn't be a shortcut for every available option if users are not currently logged in.
Re: Remove Quote and Edit button when topic is lock
Maybe we should look at how IP.Board or some other software does it, in some theme they are grayed out or marked with a red background over the text "This topic is locked".
Re: Remove Quote and Edit button when topic is lock
gray out or insert a simple javascript alert that tell user should login/ or have permission... in this way do not need lot of edition in current code:
<a href="...." onclick="alert('you must login to do this....'); return false;">
<a href="...." onclick="alert('you have not enough permission....'); return false;">
<a href="...." onclick="alert('topic closed'); return false;">
etc.
<a href="...." onclick="alert('you must login to do this....'); return false;">
<a href="...." onclick="alert('you have not enough permission....'); return false;">
<a href="...." onclick="alert('topic closed'); return false;">
etc.
Re: Remove Quote and Edit button when topic is lock
alerts are really not suitable for this kind of things...
Re: Remove Quote and Edit button when topic is lock
I'd remove them completely (except for moderators, as we said). If the topic is locked, is locked, and the "locked" button would be displayed as it is right now, at the end and beginning of the topic.
If people look for these buttons and don't find them they'll inmediately know that the topic is locked. There is no point in displaying 20 buttons if you can't use them.
If people look for these buttons and don't find them they'll inmediately know that the topic is locked. There is no point in displaying 20 buttons if you can't use them.
- Pony99CA
- Registered User
- Posts: 986
- Joined: Sun Feb 08, 2009 2:35 am
- Location: Hollister, CA
- Contact:
Re: Remove Quote and Edit button when topic is lock
If somebody links directly to a post in the middle of the page, the Locked buttons may well not be visible. Showing grayed Quote and Edit buttons provides useful information.Jacob wrote:I'd remove them completely (except for moderators, as we said). If the topic is locked, is locked, and the "locked" button would be displayed as it is right now, at the end and beginning of the topic.
As the buttons still seem to be graphics, they should be cached, so there's not as much penalty as your statement might imply.Jacob wrote: If people look for these buttons and don't find them they'll inmediately know that the topic is locked. There is no point in displaying 20 buttons if you can't use them.
Why not? They're better than going to a completely different page for a message that just tells you that the topic is locked.paulus wrote:alerts are really not suitable for this kind of things...
Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: Remove Quote and Edit button when topic is lock
If any change is made, I agree with either greying out the buttons. Removing the buttons in this case for users that would normally be able to perform such actions in the forum would lead to confusion and a waste of time figuring out what the issue is. Or we could replace the buttons with text like "This topic is locked. Posts cannot be edited and replies cannot be created." or something like that. But I'd lean toward just greying out the buttons.
Re: Remove Quote and Edit button when topic is lock
You're absolutely rightimkingdavid wrote: Removing the buttons in this case for users that would normally be able to perform such actions in the forum would lead to confusion and a waste of time figuring out what the issue is.
+1
Re: Remove Quote and Edit button when topic is lock
The first time. Then you would know that the topic is locked, so no confusion or waste of time from then on.imkingdavid wrote:If any change is made, I agree with either greying out the buttons. Removing the buttons in this case for users that would normally be able to perform such actions in the forum would lead to confusion and a waste of time figuring out what the issue is.
Currently there is only 1 reason for not seeing the buttons as far as I'm aware: you are not logged.
With the buttons removed there would be 2 reasons. Not a lot of chances for confusion, I think.
- I'm I logged in?
- Yes. Then the topic is locked.
- No. Then I need to log in.
Yeah, not performance-wise, but they'll still be visible. Why have a portion of the screen occupied with useless information? For me, I know you think it is usefull.Pony99CA wrote:As the buttons still seem to be graphics, they should be cached, so there's not as much penalty as your statement might imply.Jacob wrote:If people look for these buttons and don't find them they'll inmediately know that the topic is locked. There is no point in displaying 20 buttons if you can't use them.
But whatever, it's not such a big deal.