Remove Quote and Edit button when topic is lock

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
Meis2M
Registered User
Posts: 418
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Remove Quote and Edit button when topic is lock

Post by Meis2M » Mon Aug 05, 2013 5:59 pm

Hi
this topic is locked
http://www.php-bb.ir/pic/images/8487156 ... 303862.png
https://www.phpbb.com/community/viewtop ... &t=2172673

but still Quote and Edit button is showing to me.
when is i click on one of them i will see:
This topic is locked, you cannot edit posts or make further replies.
i think it is better disappear these buttons when topic is locked.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by nickvergessen » Mon Aug 05, 2013 6:02 pm

Make a ticket and send a PullRequest?
Member of the Development-TeamNo Support via PM

User avatar
Jacob
Registered User
Posts: 100
Joined: Wed Jan 04, 2012 1:41 pm

Re: Remove Quote and Edit button when topic is lock

Post by Jacob » Mon Aug 05, 2013 6:37 pm

But not for Moderators, ¿right?

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Pony99CA » Tue Aug 06, 2013 2:29 am

Keep the buttons, but "gray" them out. If the user still clicks one, pop up a JavaScript error instead of moving to a new page (unless JavaScript is disabled, of course). Also change the tooltip to say "Replies not allowed because the topic is locked".

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: Remove Quote and Edit button when topic is lock

Post by Danielx64 » Tue Aug 06, 2013 2:50 am

I would just remove then, no need to display then. Also the topic locked button doesn't need to be a link, I don't see a point.

User avatar
Ger
Registered User
Posts: 282
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Ger » Tue Aug 06, 2013 7:22 am

The point is that moderators and administrators usually have permission to reply in locked topics.
Same goes with editing, a moderator may want to lock first (to prevent further posts) and then go editing the unwanted posts.
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1751
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by DavidIQ » Tue Aug 06, 2013 3:30 pm

Pony99CA wrote:Keep the buttons, but "gray" them out. If the user still clicks one, pop up a JavaScript error instead of moving to a new page (unless JavaScript is disabled, of course). Also change the tooltip to say "Replies not allowed because the topic is locked".

Steve
If anything I'd go with the tooltip and not do the JS alert at all but I think I'd lean more towards not showing them at all.
Image

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Pony99CA » Wed Aug 07, 2013 3:08 am

DavidIQ wrote:
Pony99CA wrote:Keep the buttons, but "gray" them out. If the user still clicks one, pop up a JavaScript error instead of moving to a new page (unless JavaScript is disabled, of course). Also change the tooltip to say "Replies not allowed because the topic is locked".
If anything I'd go with the tooltip and not do the JS alert at all but I think I'd lean more towards not showing them at all.
Not seeing expected buttons can cause the user confusion. Showing them disabled lets the user know that the functions are available (in general), but not at this time in this topic. The reasoning is similar to why menu items in Windows get grayed out instead of removed.

Now if the user class doesn't allow the functions in general, then removing them is OK because the user would never be able to access them anyway (unless he was promoted to Moderator). However, that's not the case here.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: Remove Quote and Edit button when topic is lock

Post by MichaelC » Wed Aug 07, 2013 3:29 am

I would say don't show them at all unless you have the correct (moderator) permissions to use them.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Remove Quote and Edit button when topic is lock

Post by Pony99CA » Thu Aug 08, 2013 2:19 am

Before making any changes, I suggest searching for usability studies on disabling vs. hiding UI elements.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Post Reply