Attachment Downloads

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Attachment Downloads

Post by EXreaction » Fri Aug 03, 2012 7:50 pm

That seems to be a common problem with OSX...I run into issues extracting OSX zip archives from time to time myself. I'm pretty sure I used some compression framework for Titania, and we've never had any reported problems with that, have we?

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Attachment Downloads

Post by bantu » Fri Aug 03, 2012 7:53 pm

paulus wrote:For at least some archives extracting does not work correctly, IIRC, it was reported a while back by me, and davidMJ couldnt find it back then. It should be somewhere in the bugtracker. I believe it was related to zips created on osX.
I think this problem was caused by an ambiguity in the ZIP format.

Anyway, we are trying to generate ZIP files, not extract them. So this shouldn't be an issue in this case, right?

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] Attachment Downloads

Post by oddfish » Sun Aug 26, 2012 9:35 pm

The alignment of Download all attachments: [ tar ] [ gz ] [ bz2 ] [ zip ] with a padding of 10px is different to pagination of padding-top 5px (37 posts • Page 1 of 3 • 1 2 3) and is noticeably off putting.
Would it be better to correctly (visually) align?

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Attachment Downloads

Post by nickvergessen » Mon Aug 27, 2012 8:56 am

Member of the Development-TeamNo Support via PM

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Attachment Downloads

Post by bantu » Mon Aug 27, 2012 9:03 am

oddfish wrote:The alignment of Download all attachments: [ tar ] [ gz ] [ bz2 ] [ zip ] with a padding of 10px is different to pagination of padding-top 5px (37 posts • Page 1 of 3 • 1 2 3) and is noticeably off putting.
Would it be better to correctly (visually) align?
I'm not sure about the positioning of the download links at all. There probably is some room for improvement here. Feel free to make suggestions and send patches.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Attachment Downloads

Post by Pony99CA » Mon Aug 27, 2012 10:14 pm

As several users have asked for it, I would also suggest adding a consolidated download page as I suggested on phpBB.com. It would look something like the DM Easy Download System.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Attachment Downloads

Post by bantu » Mon Aug 27, 2012 10:16 pm

Pony99CA wrote:As several users have asked for it, I would also suggest adding a consolidated download page as I suggested on phpBB.com. It would look something like the DM Easy Download System.

Steve
I would consider this a different issue/feature. Feel free to create an RFC for it.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Attachment Downloads

Post by Pony99CA » Mon Aug 27, 2012 11:23 pm

The RFC Subject is "Attachment Downloads" and the consolidated page certainly fits that description. ;) In general, I'm opposed to opening multiple RFCs for similar things (as can be seen in my Improved Subscription Options RFC). It makes it harder to keep things consistent if they're separated.

Also, in this case, if you implemented the consolidated view and added post/topic filtering (and an archive option), I think that you'd have a better implementation than what seems to be suggested. While I might be interested in downloading every attachment in a post, I don't know that I'd ever be interested in doing so in the topic. (What's the use case for that? Warez or porn? :lol:)

Also, as I mentioned on the first page, I'm not even convinced that the original proposal is a real RFC. There's no description of the user interface, for example (or did I miss that?). My proposal gave a semi-detailed description with an example implementation, at least one of which I'd expect in an RFC.

So consider this a -1 on the original proposal (at least until there's an example or UI description) and a suggested alternative. ;)

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] Attachment Downloads

Post by oddfish » Mon Aug 27, 2012 11:56 pm

Looks different to me.

Anyway, here are a few thoughts to thought further on ..
  1. Change the logic with only one attachment in the topic, as it currently appears with one string assigned Download all attachments.
    • Hidden in this instance
  2. Ajax archive selection (see a & b below)
  3. Indication of a multiple attachment download system by:
    1. Attach icon on viewforum as a multiple attach icon, replacing the single attach icon when more than one attachment.
      • dl_method added to this icon in viewforum for quick download.
    2. Attach icon next to topic title.
      • Next to each post title containing an attachment.
      • As a postrow download option beside each or the last attachment download link in the containing post
    3. Move the download links to linklist leftside in viewtopic.
  4. A page with no attachments but there are multiple attachments throughout the topic.
    • A multi attach icon (dl_method) with the topic title again to indicate a multiple attachment download option applies to this topic.
oddfish.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] Attachment Downloads

Post by Vinny » Sun Sep 16, 2012 11:26 pm

oddfish wrote:Move the download links to linklist leftside in viewtopic.
I think that would be perfect link+icon/button next to the pagination.

Post Reply