phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Keep search query when search returns no results

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.1/Ascreaus followed by 3.2/Arsia.

Re: Keep search query when search returns no results

Postby Erik Frèrejean » Tue Jun 26, 2012 10:29 am

bantu wrote:
DavidIQ wrote:Looks to me like the question is if the user messes around with the query string what should the result be:
dhruv.goel92 wrote:What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link,
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?


So yes, the user did provoke the error and error message should be shown.

No.

Oleg's concern is as follows:
1. User searches and finds 2 pages of search results.
2. Moderator deletes a few posts. The search index changes.
3. User navigates to the second pages and gets the error (unprovoked).

In that case handle it as is done with topics for example. If the requests tries to display a page that doesn't exist show the last valid page.
Available on .com
Support Toolkit developer
User avatar
Erik Frèrejean
Registered User
 
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet

Re: Keep search query when search returns no results

Postby naderman » Wed Jun 27, 2012 11:11 am

One cannot distinguish between pages that don't exist because of incorrect user input and pages which do not exist because of deleted posts.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: Keep search query when search returns no results

Postby callumacrae » Wed Jun 27, 2012 7:02 pm

naderman wrote:One cannot distinguish between pages that don't exist because of incorrect user input and pages which do not exist because of deleted posts.

Wasn't soft delete planned for 3.1?
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Keep search query when search returns no results

Postby imkingdavid » Wed Jun 27, 2012 7:43 pm

callumacrae wrote:
naderman wrote:One cannot distinguish between pages that don't exist because of incorrect user input and pages which do not exist because of deleted posts.

Wasn't soft delete planned for 3.1?

Features that were "planned for 3.1" in the feature freeze may or may not make it into 3.1. The way it's working now is if a feature is ready by the time events, extensions, etc. get done, then it can be included. Otherwise, it will have to wait. So after extensions/events/etc., features will not be considered "for version X".

That being said, I do believe that it is one of the items nickvergessen plans to work on sometime soon, if I'm not mistaken.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 906
Joined: Thu Jul 30, 2009 12:06 pm

Re: Keep search query when search returns no results

Postby Oleg » Thu Jun 28, 2012 2:45 am

Soft delete has nothing to do with this.
Oleg
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Keep search query when search returns no results

Postby DavidIQ » Thu Jun 28, 2012 2:53 am

If we are talking about extending beyond the final page then just show an error that there are no more results to show and leave it at that. I don't think this would happen because of some "natural" occurence that often anyways (moderator deleted last page of posts in the results).
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 772
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: Keep search query when search returns no results

Postby Oleg » Thu Jun 28, 2012 6:10 am

Why do you want to give users errors when you can trivially correct them to the last usable page? What is user meant to do when they receive an error in this situation? Go to the previous page? If so why not send them there right away?

There are two situations in which a user may request a nonexistent page:

1. Search result set changed under user. User is unaware that this happened, and most likely doesn't want to deal or even be aware of this. If they get the last page of results at most they will be slightly confused, but now the "next" page link won't exist therefore hopefully they understand the situation. The alternative isn't any better in my opinion confusion-wise: as I follow a link to the next page I should not be receiving an error message telling me the page does not exist!

2. User requested the nonexistent page intentionally. Assuming they were trying to jump forward as opposed to being malicious, why not give them an approximation of what they presumably want rather than complain that their input wasn't valid?

I'm just not seeing the benefit of displaying error pages in any of the use cases.

The best way of handling this, in my opinion, would be to display a notice saying "You requested page X but there are only Y pages in this result set, page Y is shown". I believe there is a flash/notice RFC which could be relevant here.
Oleg
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Keep search query when search returns no results

Postby callumacrae » Thu Jun 28, 2012 7:05 am

Oleg wrote:Soft delete has nothing to do with this.

But it was *far* more on topic than your post was.

Although, it had everything to do with the post I quoted. Why not try thinking about it? I know you like things explaining to you, but it really isn't that tricky to understand...

DavidIQ wrote:If we are talking about extending beyond the final page then just show an error that there are no more results to show and leave it at that. I don't think this would happen because of some "natural" occurence that often anyways (moderator deleted last page of posts in the results).


+1
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Keep search query when search returns no results

Postby DavidIQ » Thu Jun 28, 2012 10:38 am

Oleg wrote:Why do you want to give users errors when you can trivially correct them to the last usable page? What is user meant to do when they receive an error in this situation? Go to the previous page? If so why not send them there right away?

There are two situations in which a user may request a nonexistent page:

1. Search result set changed under user. User is unaware that this happened, and most likely doesn't want to deal or even be aware of this. If they get the last page of results at most they will be slightly confused, but now the "next" page link won't exist therefore hopefully they understand the situation. The alternative isn't any better in my opinion confusion-wise: as I follow a link to the next page I should not be receiving an error message telling me the page does not exist!

2. User requested the nonexistent page intentionally. Assuming they were trying to jump forward as opposed to being malicious, why not give them an approximation of what they presumably want rather than complain that their input wasn't valid?

I'm just not seeing the benefit of displaying error pages in any of the use cases.

The best way of handling this, in my opinion, would be to display a notice saying "You requested page X but there are only Y pages in this result set, page Y is shown". I believe there is a flash/notice RFC which could be relevant here.

Then maybe there should be no message at all. If there are only 20 pages of results and the user tries to go to page 25 then the user should just be taken to the last page. Scenario 1 is going to be a very very rare occurence in my opinion.
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 772
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: Keep search query when search returns no results

Postby bantu » Thu Jun 28, 2012 7:03 pm

callumacrae wrote:
Oleg wrote:Soft delete has nothing to do with this.

But it was *far* more on topic than your post was.

It has nothing to do with this issue. We can not consider every hypothetical feature when implementing other features or fixing bugs. The developer of soft-delete has to make sure everything is still working as intended as long as soft delete is not merged.

Oleg wrote:The best way of handling this, in my opinion, would be to display a notice saying "You requested page X but there are only Y pages in this result set, page Y is shown".

I agree. As a slightly weaker solution: Just redirect to the last valid page.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 439
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Previous Next

Return to [3.x] Discussion

Who is online

Users browsing this forum: No registered users and 9 guests