Handling base64 images in the [img] tag.

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Handling base64 images in the [img] tag.

Post by Oleg »

Error message for what? Misuse of a feature we don't have?
User avatar
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Handling base64 images in the [img] tag.

Post by callumacrae »

I don't see why an error message is needed. Of they try it and it doesn't work, then it doesn't work.
Made by developers, for developers!
My blog
User avatar
Registered User
Posts: 35
Joined: Sun Apr 09, 2006 3:38 am
Location: Texas

Re: Handling base64 images in the [img] tag.

Post by Freitag »

Actually I think that any tag that gets input that is unexpected ought to display an error message. For instance the URL tag if it gets a badly formed URL. Most posts don't get a preview before they're submitted, so on that page that pops up after submission would be a good place to post the message. Something like "Some problems were found in your post" - then have a list of what issues were found like "the image tag found content that it was unable to parse" or "the image tag found something that was not an URL"

I agree that this would be a feature used by a minority of users, my first thought is that the only place I've seen it in use is with emails. Leaving this to be implemented as a MOD is a good idea. I might make a suggestion for that MOD, convert the image from the text representation and save it as an actual file on the server. If you're going to server the image anyway, let Apache take care of the static content and don't munge up what's in the database with several thousand bytes of MIME text.

I might also suggest for that MOD that any image on remote servers be (optionally) copied locally - it would solve that problem previously noted about remote server issues and files that get removed.
Am I?
Post Reply