Load default language before other languages?

[naderman]

Having worked with the language loading code a bit. I think it might need a complete refactoring and removal from user class anyway.

[MartinTruckenbrodt]

Hello Nils,
at the moment I'm thinking about doing an Advanced Multi Language Support MOD for Olympus to to add all of the told missing core features. Maybe I will do it in June or July.

I think I will add a function which looks for existing language files. If at least one file is missing then the complete default board language pack will be used then merged/overwritten with the exisiting user language pack things.

I hope that you understand my English. If not then please let me know for a german language PM.

Bye Martin

[imkingdavid]

Do we have benchmarks on page loading speed with and without this change? If it is not a significant difference (will need testing on a largish board), then I'm okay with doing this.

Perhaps consider caching it, so that it only has to include both files once and then always has a value stored in cache afterwards, so it only has to load the cache any subsequent times (until cache is cleared, of course).

[MartinTruckenbrodt]

Hello imkingdavid,
I don't how the cache works. But I think the cache is not related to the user. Yes? So I think there should be not a big difference.

BTW. The cache here on Area51 at the moment is not running well. At least for me.

Bye Martin

[imkingdavid]

Hello imkingdavid,
I don't how the cache works. But I think the cache is not related to the user. Yes? So I think there should be not a big difference.

Yes, but language entries aren't user-specific either. Simply cache language entries as they are used. If a certain language is requested, first check the cache and see if it has been cached yet, otherwise look for the file and cache that.

[naderman]

Hello Nils,
at the moment I'm thinking about doing an Advanced Multi Language Support MOD for Olympus to to add all of the told missing core features. Maybe I will do it in June or July.

I think I will add a function which looks for existing language files. If at least one file is missing then the complete default board language pack will be used then merged/overwritten with the exisiting user language pack things.

Please work on a propert patch which is going to be useful for all phpBB users, rather than a MOD. With phpBB 3.1 we won't be advertising MODs at all anymore anyway.

[Dragosvr92]

When i have installed my forum, i started installing language packs for each user that was speaking different languages (German, Greek, Korean etc) But as there were errors because the language packs werent having the translation for mods, i have removed them all and let just British English, as it would have been easier to install mods in just one language. It would be really amazing to have the language packs of other countries to just translate the main forum files, and load the extra language edits that are made by an x mod.

[MartinTruckenbrodt]

Hello Nils,
I'm a MOD author and no co-developer. I don't advertise MODs. I advertise missing core features.
Perhaps MODs should been written like patches in future?

Bye Martin

[callumacrae]

Contributions to the core aren't accepted as patches, so that wouldn't really achieve anything.

[brunoais]

Perhaps consider caching it, so that it only has to include both files once and then always has a value stored in cache afterwards, so it only has to load the cache any subsequent times (until cache is cleared, of course).

This ^