Signature Preview by Default

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.2.x. If you need support for phpBB 3.2.x please visit the 3.2.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Signature Preview by Default

Post by imkingdavid »

EDIT: To clarify, I have quoted a more detailed explanation of what I mean from a later post:
The preview button can (and should remain). The signature should, however, be displayed above the editor by default without having to press "preview". If a change is made in the editor, the user can click "Preview" to view the update (though there should be some indicator that what they are viewing is not live/changes aren't saved). If we can implement live preview and WYSIWYG for that editor as well, all the better, but that is not necessarily in the scope of this request.
(Original post)
In order to view your signature when editing it, you have to click preview. I propose that it should automatically be loaded when the signature edit page is loaded. This would save time and remove the need for a Preview button.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Signature Preview by Default

Post by naderman »

Moving this to discussion, because it's not sufficiently precise for an RFC. Please explain how this would be implemented. I imagine via AJAX so the preview is updated while editing? That requires javascript, so we sill need the preview button as a fallback. It may be hidden by the same javascript handling the updating of the preview though.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Signature Preview by Default

Post by imkingdavid »

I hadn't really considered a live preview. I was more just thinking of removing the "preview" functionality by simply starting out with the signature display above the edit box. But a live preview would be a neat idea.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: Signature Preview by Default

Post by Vinny »

imkingdavid wrote:In order to view your signature when editing it, you have to click preview. I propose that it should automatically be loaded when the signature edit page is loaded. This would save time and remove the need for a Preview button.
+1
naderman wrote:I imagine via AJAX so the preview is updated while editing?
I think that the button should be maintained and the preview is loaded with Ajax (clicking on the button).

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Signature Preview by Default

Post by naderman »

Ah I see what you mean now. It sounded like you were suggesting the removal of the current preview functionality. Wouldn't call this signature preview by default, but something like view old signature while editing ;-)

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Signature Preview by Default

Post by imkingdavid »

naderman wrote:Ah I see what you mean now. It sounded like you were suggesting the removal of the current preview functionality. Wouldn't call this signature preview by default, but something like view old signature while editing ;-)
Well basically it removes the need for the preview because there would be no point at which the "preview" is not displayed, if you get what I mean...
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1840
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Signature Preview by Default

Post by DavidIQ »

Then how would you preview the currently edited signature?
Image

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: Signature Preview by Default

Post by naderman »

imkingdavid wrote:
naderman wrote:Ah I see what you mean now. It sounded like you were suggesting the removal of the current preview functionality. Wouldn't call this signature preview by default, but something like view old signature while editing ;-)
Well basically it removes the need for the preview because there would be no point at which the "preview" is not displayed, if you get what I mean...
But that would only work if you have some kind of live update function? Otherwise you still need the preview button to update that preview? Just because it's always displayed doesn't magically update it when you make changes?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Signature Preview by Default

Post by imkingdavid »

Fair point. Yes, a live preview would be a good idea, but the preview button would otherwise still need to be kept. I didn't think that through. :lol:
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: Signature Preview by Default

Post by callumacrae »

imkingdavid wrote:Fair point. Yes, a live preview would be a good idea, but the preview button would otherwise still need to be kept. I didn't think that through. :lol:
It would need to be kept anyway, as a fallback (although I guess that it could be hidden using javascript).
Made by developers, for developers!
My blog

Post Reply