phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Adding Round Corners On Quote box

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.1/Ascreaus followed by 3.2/Arsia.

Adding Round Corners On Quote box

Postby Dragosvr92 » Tue Aug 16, 2011 2:07 pm

Hey, I think it would be nice if we would have Round corners on the Quote box.
I think it may be easy to add it by using the Existing Round cornered images that are used in other parts of the styles.
I did what i touch it may be simplyer, and added HTML5 on making round corners on my forum
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Adding Round Corners On Quote box

Postby callumacrae » Tue Aug 16, 2011 2:45 pm

TheKiller wrote:Hey, I think it would be nice if we would have Round corners on the Quote box.
I think it may be easy to add it by using the Existing Round cornered images that are used in other parts of the styles.
I did what i touch it may be simplyer, and added HTML5 on making round corners on my forum

That's a style thing, mostly.

On prosilver, I don't like it:

Image
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Adding Round Corners On Quote box

Postby Dragosvr92 » Tue Aug 16, 2011 4:27 pm

Yes, but if its a default phpbb feature, other style authors might be interested in keeping it.
Well....... Now that i think Better it might not be such a great idea on doing this :? :? :?

Btw, You've used Firebug to add the round corners on the test page?
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Adding Round Corners On Quote box

Postby callumacrae » Wed Aug 17, 2011 10:40 am

TheKiller wrote:Btw, You've used Firebug to add the round corners on the test page?

Chrome Dev Tools <3

I really don't like Firefox
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Adding Round Corners On Quote box

Postby Dragosvr92 » Wed Aug 17, 2011 4:19 pm

callumacrae wrote:Chrome Dev Tools <3

I really don't like Firefox

Whooo.. Blasphemy ! Firefox Ruleezz :P
If im not mistaken, Chrome took the Addon from Firefox and added it to theirs. Or the authorthat made the addon for FF made it for chrome too.
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Adding Round Corners On Quote box

Postby VSE+ » Mon Sep 12, 2011 7:18 am

I actually kinda like that. After all, Prosilver is all about the rounded corners! :geek:
User avatar
VSE+
Registered User
 
Posts: 205
Joined: Mon Mar 08, 2010 9:18 am

Re: Adding Round Corners On Quote box

Postby Dragosvr92 » Mon Sep 12, 2011 10:45 am

I Like it also, i think it makes the quote box prettyer, but some dont seem to like it, lol
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Adding Round Corners On Quote box

Postby callumacrae » Mon Sep 12, 2011 4:16 pm

TheKiller wrote:If im not mistaken, Chrome took the Addon from Firefox and added it to theirs. Or the authorthat made the addon for FF made it for chrome too.

Nope, chrome dev tools was written by the chrome dev team and isn't a plugin.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Adding Round Corners On Quote box

Postby nickvergessen » Tue Sep 13, 2011 11:07 am

callumacrae wrote:Nope, chrome dev tools was written by the chrome dev team and isn't a plugin.

offtopic: https://groups.google.com/forum/#!topic ... NCZeL1eWq8

Regarding the rounded corners, you may just set up a brnach/patch so we can see the amount of work it needs.
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: Adding Round Corners On Quote box

Postby Dragosvr92 » Tue Sep 13, 2011 2:57 pm

hmmmm..... im not sure what do you mean by the patch exactly.
All i did was to add the border-radius element on the blockquote class.

Heres the example.
Code: Select all
/* BB Code styles
----------------------------------------*/
/* Quote block */
blockquote {
   background: #ebebeb none 6px 8px no-repeat;
   border: 1px solid #dbdbdb;
   font-size: 0.95em;
   margin: 0.5em 1px 0 25px;
   overflow: hidden;
   padding: 5px;

   /* Rounded border */
   border-radius:9px;
   -moz-border-radius:9px;
   -webkit-border-radius:9px;
   /* Rounded border */
}


Thats all the work there is, imo. If i heared right, you've added the HTML5 Doctype. Will you start using CSS3 And HTML5 also?
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Next

Return to [3.x] Discussion

Who is online

Users browsing this forum: No registered users and 13 guests

cron