Attachments settings (allow/deny downloads)

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The next feature release of phpBB 3 will be 3.2/Rhea followed by 3.3.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.1. If you need support for phpBB 3.1 please visit the 3.1.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
rubencm
Registered User
Posts: 7
Joined: Sun Mar 12, 2017 8:30 pm

Attachments settings (allow/deny downloads)

Post by rubencm » Sun Jul 16, 2017 4:48 am

As I commented some days ago, i think that allow/deny policy in attachments settings in acp doesnt have much sense.
Actually is something like this:

Image

Image

I propose to change it to this:

Image
(where the textbox could be a list or something)
Last edited by rubencm on Sun Jul 16, 2017 5:22 pm, edited 1 time in total.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1715
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Attachments settings (allow/deny downloads)

Post by DavidIQ » Sun Jul 16, 2017 11:11 am

You mean get rid of both sections and just have the one? Makes less sense if you do that. Not seeing how this is an improvement tbh.
Image

rubencm
Registered User
Posts: 7
Joined: Sun Mar 12, 2017 8:30 pm

Re: Attachments settings (allow/deny downloads)

Post by rubencm » Sun Jul 16, 2017 2:04 pm

Allow/Deny and then Exclude/Include is very confuse

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1715
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Attachments settings (allow/deny downloads)

Post by DavidIQ » Sun Jul 16, 2017 2:09 pm

This is the same exact concept that is laid out in the banning screens. Is that confusing as well?
Image

rubencm
Registered User
Posts: 7
Joined: Sun Mar 12, 2017 8:30 pm

Re: Attachments settings (allow/deny downloads)

Post by rubencm » Sun Jul 16, 2017 3:13 pm

With this system, how do you allow downloads for everyone except for google.com?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1715
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Attachments settings (allow/deny downloads)

Post by DavidIQ » Sun Jul 16, 2017 3:24 pm

This actually doesn't follow our banning workflow the more I look at it. Might be worth it to just align with that. I had missed the radio buttons at the top of the first screenshot...
Image

User avatar
3Di
Registered User
Posts: 692
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: Attachments settings (allow/deny downloads)

Post by 3Di » Mon Jul 17, 2017 3:28 am

I am seeing this as a good improvement, it is a black/white list of sort.

Like the "phantomatic" zebra, which should be also reviewed.. another case.

Indispensable IMO also and especially for the PMs system, which have priority IMHO.
Would be very nice to allow/deny on a per user basis the "power" to PM an user, some people abuse of that facility being generally just a boolean, you can onlu allow or not users to PM you, you cannot decide who can and who not.
Especially when you have notifications via email based on PMs, that's freedom of choice.

Regards.
Want to compensate me for my interest? Don't ask me, just do it
I'm available for custom phpBB jobs, you can PM me the details.
New: my Live Board, Extensions and Tools for phpBB - Men at works.

rubencm
Registered User
Posts: 7
Joined: Sun Mar 12, 2017 8:30 pm

Re: Attachments settings (allow/deny downloads)

Post by rubencm » Tue Jul 18, 2017 5:52 am

Also, rules could be defined with something like this (only with actions allow/block):

Image

But with host/ip as columns. It would be a little more complex, but with more functionality

Post Reply