phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Placeholder for search box.

These requests for comments have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.

Re: Placeholder for search box.

Postby DavidIQ » Thu Jul 19, 2012 8:00 pm

callumacrae wrote:Also, with "Search" it isn't too clear what the box does.
So maybe while we're at it a title attribute could be added to the search box with an explanation of what the box does.
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 759
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: Placeholder for search box.

Postby callumacrae » Thu Jul 19, 2012 8:21 pm

That was supposed to say "without". Fixing now - I think it's clear enough when the placeholder is displayed.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Placeholder for search box.

Postby Dragosvr92 » Thu Jul 19, 2012 8:26 pm

3.1.0 already has a title attribute, 3.0.10 doesnt...
Code: Select all
<input type="text" onblur="if(this.value=='')this.value='Search…';" onclick="if(this.value=='Search…')this.value='';" value="Search…" class="inputbox search" title="Search for keywords" maxlength="128" id="keywords" name="keywords"
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Placeholder for search box.

Postby naderman » Thu Jul 19, 2012 11:10 pm

From a functional perspective this is an unnecessary neat UI addition, so I think all JS can be dropped entirely in favour of the new attribute. There's no need for a fallback here.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: Placeholder for search box.

Postby Vinny » Thu Jul 26, 2012 12:37 am

I'm preparing this change, and want to know: Is someone working on this?
User avatar
Vinny
Styles Team
Styles Team
 
Posts: 91
Joined: Thu May 20, 2010 4:01 am
Location: Brazil

Re: Placeholder for search box.

Postby Dragosvr92 » Fri Aug 10, 2012 5:03 pm

This will be only added in Ascraeus, right?
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Placeholder for search box.

Postby Vinny » Fri Aug 10, 2012 5:32 pm

TheKiller wrote:This will be only added in Ascraeus, right?

Placeholder is an new attribute of HTML5 and only Ascraeus use this doctype, so... the answer is yes.
User avatar
Vinny
Styles Team
Styles Team
 
Posts: 91
Joined: Thu May 20, 2010 4:01 am
Location: Brazil

Re: Placeholder for search box.

Postby brunoais » Sat Aug 11, 2012 11:05 am

Vinny wrote:
TheKiller wrote:This will be only added in Ascraeus, right?

Placeholder is an new attribute of HTML5 and only Ascraeus use this doctype, so... the answer is yes.

*coff* see source code of this page *coff* see the source code of prosilver (in phpBB 3.1-dev).
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: Placeholder for search box.

Postby callumacrae » Sat Aug 11, 2012 4:47 pm

brunoais wrote:
Vinny wrote:
TheKiller wrote:This will be only added in Ascraeus, right?

Placeholder is an new attribute of HTML5 and only Ascraeus use this doctype, so... the answer is yes.

*coff* see source code of this page *coff* see the source code of prosilver (in phpBB 3.1-dev).

What?
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Placeholder for search box.

Postby brunoais » Sun Aug 12, 2012 7:03 am

^
Sorry mixed up names. AGAIN! :oops:
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Previous Next

Return to [3.1/Ascraeus] Merged RFCs

Who is online

Users browsing this forum: No registered users and 6 guests