phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Handling base64 images in the [img] tag.

Discuss the future of phpBB. It is still nesting in its mother's womb, but it will grow a little bigger each day. Participate in its design & planning here.

Re: Handling base64 images in the [img] tag.

Postby Oleg » Thu Jun 28, 2012 6:07 am

Error message for what? Misuse of a feature we don't have?
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Handling base64 images in the [img] tag.

Postby callumacrae » Thu Jun 28, 2012 7:07 am

I don't see why an error message is needed. Of they try it and it doesn't work, then it doesn't work.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Handling base64 images in the [img] tag.

Postby Freitag » Sat Jun 30, 2012 1:12 pm

Actually I think that any tag that gets input that is unexpected ought to display an error message. For instance the URL tag if it gets a badly formed URL. Most posts don't get a preview before they're submitted, so on that page that pops up after submission would be a good place to post the message. Something like "Some problems were found in your post" - then have a list of what issues were found like "the image tag found content that it was unable to parse" or "the image tag found something that was not an URL"

I agree that this would be a feature used by a minority of users, my first thought is that the only place I've seen it in use is with emails. Leaving this to be implemented as a MOD is a good idea. I might make a suggestion for that MOD, convert the image from the text representation and save it as an actual file on the server. If you're going to server the image anyway, let Apache take care of the static content and don't munge up what's in the database with several thousand bytes of MIME text.

I might also suggest for that MOD that any image on remote servers be (optionally) copied locally - it would solve that problem previously noted about remote server issues and files that get removed.
Am I?
User avatar
Freitag
Registered User
 
Posts: 35
Joined: Sun Apr 09, 2006 3:38 am
Location: Texas

Previous

Return to [4.x] Discussion

Who is online

Users browsing this forum: No registered users and 6 guests