Caching module

Discuss features as they are added to the new version. Give us your feedback. Don't post bug reports, feature requests, support questions or suggestions here.
Forum rules
Discuss features as they are added to the new version. Give us your feedback. Don't post bug reports, feature requests, support questions or suggestions here. Feature requests are closed.
Post Reply
haklop
Registered User
Posts: 2
Joined: Sun Mar 27, 2011 6:50 am

Caching module

Post by haklop » Sun Mar 27, 2011 7:51 am

Hi everyone

I'm not sure where to post but I have develop a caching module for Redis. Redis is a key-value database. It is similar to memcached but the dataset is not volatile and other datatypes (such as lists and sets) are natively supported (http://redis.io/). I wrote the code for 3.0-dev and for 3.1-dev with the restructured ACM classes (http://tracker.phpbb.com/browse/PHPBB3-9983).
I would like to know if this caching module count as an improvement of ACM, a new feature or just a mod ?
Do I have just to open 2 tickets (one for 3.0-dev and the other for 3.1-dev) and then pull a request in github ? Or maybe it is just considered as a mod and I have to submit it to the MOD database ?

I attached the file for 3.0.
Thank's :-)
Attachments
acm_redis.zip
(1.13 KiB) Downloaded 940 times

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Caching module

Post by Oleg » Mon Mar 28, 2011 7:57 am

I like the idea here, my only concern with adding code requiring external dependencies is that developers would need to install additional software to test this code.

One issue with something like memcached is that a server restart loses all data (thus for example logging everyone out). Redis is still very quick but is persistent, and can be restarted without losing sessions.

Additionally, there are apparently four php redis extensions (http://stackoverflow.com/questions/2001 ... ule-to-use). How much work is it going to be to support all working/presently maintained extensions?

Please make a single ticket, you can create multiple pull requests for one ticket.

Some adjustments will need to be made:

- Add constants to coding guidelines document in doc subdirectory (search for memcached constants to see what I mean)
- Some whitespace needs to be adjusted
- ?> needs to be removed

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Caching module

Post by Oleg » Mon Mar 28, 2011 7:59 am

Moved to 3.0 new features discussion for now.

haklop
Registered User
Posts: 2
Joined: Sun Mar 27, 2011 6:50 am

Re: Caching module

Post by haklop » Mon Mar 28, 2011 9:22 am

nn- wrote:Additionally, there are apparently four php redis extensions (http://stackoverflow.com/questions/2001 ... ule-to-use). How much work is it going to be to support all working/presently maintained extensions?
Only phpredis is a php extension. The other are php frameworks using sockets. If necessary, I could support all of them.
nn- wrote:Some adjustments will need to be made:
- Add constants to coding guidelines document in doc subdirectory (search for memcached constants to see what I mean)
- Some whitespace needs to be adjusted
- ?> needs to be removed
I do it and I will create the ticket.

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Caching module

Post by igorw » Mon Mar 28, 2011 10:42 am

I don't see a reason not to include this in 3.0. If you could make a pull request for each that would be great. Only supporting phpredis seems like a good option to me.

Thanks for your contribution!

Post Reply