I have noticed one particular aspect of it which gives me some cause for thought. At present, the Last-Modified HTTP header and <updated> XML field both use time() which isn't exactly accurate or helpful. Here are the obvious spots which I'm thinking of, but there may be other spots in the code which could do with a tweak to make time/date more accurate:
- Code: Select all
'FEED_UPDATED' => $user->format_date(time(), $feed_date_format, true),
and
- Code: Select all
header("Last-Modified: " . gmdate('D, d M Y H:i:s', time()) . ' GMT');
Something like one of the following, depending on context, could be used instead of time(), and would be accurate nearly 100% of the time:
- Code: Select all
SELECT MAX(forum_last_post_time) FROM phpbb_forums;
- Code: Select all
SELECT MAX(topic_last_post_time) FROM phpbb_topics;
- Code: Select all
SELECT forum_last_post_time FROM phpbb_forums WHERE forum_id=$forum_id;
- Code: Select all
SELECT topic_last_post_time FROM phpbb_topics WHERE topic_id=$topic_id;
Also, adding something similar to the following would probably be appropriate with a more accurate Last-Modified:
- Code: Select all
header('Expires: ' . gmdate('D, d M Y H:i:s', time()+$config['feed_expires']) . ' GMT');
Another suggestion I have is to add $sort_days and $cache_time to the ACP page, as neither of those are really one-size fits all (although admittedly shouldn't be a significant issue for the huge sites to pop inside the code to tweak them).
Other than that, I reckon it looks pretty good.
Can you add this to our bug tracker at the main site?
