Font resizing method in prosilver

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Post Reply
User avatar
th23
Registered User
Posts: 112
Joined: Sat Jul 03, 2004 4:26 pm
Location: Bonn, Germany
Contact:

Font resizing method in prosilver

Post by th23 »

Hi,

I just digged a little into the new font resizing button and its function in prosilver. Maybe a short discussion might enlighten me there...

Why is all this done via JavaScript while everywhere else JS is avoided if possible? Why is it not realized via sessions for guests / user_data for logged in users? Instead now there is an additional cookie used to store/restore information. I have not yet found any good reason for the current implementation...anybody else any ideas?

Thanks
th23
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: Font resizing method in prosilver

Post by Arty »

Javascript is the only method to immediately switch font size. Otherwise page has to be reloaded, and that's not a good idea if user accedently clicked font size button because he'll have to wait long to click it few more times to restore to default font size if he doesn't like large text.
User avatar
th23
Registered User
Posts: 112
Joined: Sat Jul 03, 2004 4:26 pm
Location: Bonn, Germany
Contact:

Re: Font resizing method in prosilver

Post by th23 »

Well, I'm sure if this explanation is "good enough"... If somebody hits it accidentally, I would recommend a button that allows (+) / (-) / (default) so you avoid multiclicking/page reloads. Maybe a suggestion for the devs?
User avatar
Nicholas the Italian
Registered User
Posts: 659
Joined: Mon Nov 20, 2006 11:19 pm
Location: 46°8' N, 12°13' E
Contact:

Re: Font resizing method in prosilver

Post by Nicholas the Italian »

th23 wrote: Well, I'm sure if this explanation is "good enough"... If somebody hits it accidentally, I would recommend a button that allows (+) / (-) / (default) so you avoid multiclicking/page reloads. Maybe a suggestion for the devs?

Yeah, you could split the image in two and if you click on the left the size decreases, on the right it increases.
Jhong
Registered User
Posts: 50
Joined: Tue Dec 26, 2006 3:28 pm

Re: Font resizing method in prosilver

Post by Jhong »

On the contrary, I recommend ditching it. This doesn't need to be done in script. Stop hard-coding the font in pixels and then everyone, including IE6 users (like me... at work Grrr) will be able to resize at will.. *without* refreshing the page.
User avatar
th23
Registered User
Posts: 112
Joined: Sat Jul 03, 2004 4:26 pm
Location: Bonn, Germany
Contact:

Re: Font resizing method in prosilver

Post by th23 »

Okay, seems not so many people having an issue with it / are thinking about...

Anyway, I made a MOD to support A+ / Default / a- buttons and storage in user/session table. Once phpBB team allows to make it public, I'll post it here.

Thanks
th23
Post Reply