Attachments in 2.2

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
odie3
Registered User
Posts: 3
Joined: Sat Mar 06, 2004 10:58 pm
Location: Kyle, TX
Contact:

Attachments in 2.2

Post by odie3 »

I was woundering how attachments are (or will) be handled in 2.2. Will it be much like in the attachment MOD for 2.0.x? Where the attached files are stored in a CHMOD'ed 777 folder or on a FTP site with the user/password in clear text in the Database?

From what I understand there will be a upgrade path from 2.0.x attachments to 2.2.x, so I assume they are a bit alike. If so, there is a MOD author out there that will dislike this a lot [I think he hates the attachment MOD will not support attachment MOD on his MOD's at all].

Odie3
User avatar
espenhh
Registered User
Posts: 189
Joined: Sun Mar 17, 2002 8:27 pm
Location: Norway ;)
Contact:

Re: Attachments in 2.2

Post by espenhh »

They are stored in the folder phpBB2/files/ ... I assume this folder must have write-permissions...
Espen

(Huge thanks to the phpBB-developers!!!)

Need Norwegian support????
Image
Martin Blank
Registered User
Posts: 687
Joined: Sun May 11, 2003 11:17 am

Re: Attachments in 2.2

Post by Martin Blank »

odie3 wrote:If so, there is a MOD author out there that will dislike this a lot [I think he hates the attachment MOD will not support attachment MOD on his MOD's at all].
That's his call if he doesn't want to support it. It will be an integrated feature set (barring some catastrophic change that results in this fairly significant portion of code being ripped out), so he'll have to live with it being in the native code if he wants to write mods for 2.2.
You can never go home again... but I guess you can shop there.
User avatar
Ptirhiik_
Registered User
Posts: 526
Joined: Tue Nov 18, 2003 8:35 am

Re: Attachments in 2.2

Post by Ptirhiik_ »

odie3 wrote:[I think he hates the attachment MOD will not support attachment MOD on his MOD's at all].
I think you are talking about me, so let's fix a point : it is not the mod itself that's problematic for me, at contrary it is one of the most well written mod on phpBB. This is the the aim itself and the philosophy I'm not and probably won't support : having public upload functions on a site is very close to give your ftp keys, with all what this imply. Attachment is a feature I hardly doubt to ever enable on 2.2, and most probably I will remove the upload code. This has btw already been discuss some monthes ago in this very forum, if you want to refer to the previous thread.
odie3
Registered User
Posts: 3
Joined: Sat Mar 06, 2004 10:58 pm
Location: Kyle, TX
Contact:

Re: Attachments in 2.2

Post by odie3 »

Yes Ptirhiik I was talking about you. ;) I did do a search and nothing came up. I just did a search on topics with your name in it and the oldest thread is Aug 31st. So either search does not work well yet or that thread has been auto-deleted (or lost in a upgrade). Also note, I was not trying to imply that you thought that the Attachment MOD was badly written, just that you disliked (or hated) the way it works [CMOD 777/Clear Text User/Password]. Seeing that you are planning to rip out of 2.2 the attachment code, hate is not to harsh a word.

IMHO, now that attachments are *officially* supported by phpBB you should at the very least make your MOD's work with attachments [in phpBB 2.2.x]

I believe I have *every* MOD that you have written for phpBB 2.0.x. Your stuff is the greatest . Heck, put up a PayPal account and I will gladly support your work in any way I could (and others should to - IMO].

But I also have the Attachment MOD too. So as a Forum Admin I am in the middle of this issue. Right now with phpBB 2.0.x I do not press the issue at your site about attachments since it is not *Offical* 2.0.x code. With phpBB 2.2.x I see myself as an Admin stuck out to dry if you write your MOD's out side of the new Attachment code.
User avatar
Acyd Burn
Posts: 1838
Joined: Tue Oct 08, 2002 5:18 pm
Location: Behind You
Contact:

Re: Attachments in 2.2

Post by Acyd Burn »

Sorry, but i do not get the point. The attachment mod and the attachment functionality implemented in 2.2 are in some respects the same and in some not (speaking about features), the ftp upload for example was removed completely.
But to say the way of doing uploads is "wrong" just because it uploads to a folder by using the php functions (and requiring this folder to be set writable, which is the case for avatars and the cache directory too) is just out of my way.
We are not talking about FTP here, this was a widely requested feature and i implemented it into the Mod as another, different choise of uploading. The default one is still the method used for avatars, smilies (admin panel), icons (admin panel)... too.
For those not wanting attachments, they are able to be disabled. For those not having the space, the feature can be disabled. For those allowing malicious file types... they should disable it too for their own good (there are some hardcoded forbidden extensions, you never know).

And i might add that the Attachment Mod and the attachment functionality implemented here is more different then most think (code wise of course), feature wise a lot has been removed for simplicity and to not produce a bloated attachment feature... some nice things were added too.

And please do not bring the "store files within the database" argument... it is the worst thing you can do. :)

Image
User avatar
Ptirhiik_
Registered User
Posts: 526
Joined: Tue Nov 18, 2003 8:35 am

Re: Attachments in 2.2

Post by Ptirhiik_ »

Let say avatars can be linked to another site (just like url/img bbcodes for files), and caches are only generated with board-property data (tables or templates ressources). Other upload are users trustable content, which is the very week point of this philosophy. Show me a board allowing upload, I will show you how to upload megas and megas and how to leech your bandwith (what is doable btw with stored avatars) even if you set small quota per users ("you" is not personnal, I'm confident you know how to do too :)). Not mentioning the main uses of attachments are upload of pictures (what is in most of case fine) and distribution of hacked programs, unlicensed copies, etc...
Martin Blank
Registered User
Posts: 687
Joined: Sun May 11, 2003 11:17 am

Re: Attachments in 2.2

Post by Martin Blank »

Ptirhiik_ wrote:Show me a board allowing upload, I will show you how to upload megas and megas and how to leech your bandwith (what is doable btw with stored avatars) even if you set small quota per users ("you" is not personnal, I'm confident you know how to do too :)).
My forum has files available to a limited subset of the users through a link to a PHP page that streams the file from outside of the public paths. Unless you're logged in <i>and</i> part of this group, you don't get anything except for an error page. There's no uploading involved, though, so it's not quite an analogue. One can also use .htaccess files to help prevent leeching of files.
You can never go home again... but I guess you can shop there.
link92
Registered User
Posts: 46
Joined: Sat Mar 27, 2004 2:43 pm
Location: In front of my Computer
Contact:

Re: Attachments in 2.2

Post by link92 »

Acyd Burn wrote:And please do not bring the "store files within the database" argument... it is the worst thing you can do. :)
Agreed.
Bored as hell. May as well put myself through the (X)HTML validator to see how invalid I am.
User avatar
Madcow
Registered User
Posts: 18
Joined: Sat May 31, 2003 1:54 am
Location: Lost in the wonder of Area51
Contact:

Re: Attachments in 2.2

Post by Madcow »

I use the forum attachment feature alot on my board. I used forum permissions to restrict upload access to only people I authorize. I also have it set to upload files to other webspace that I have.

I use attach MOD mainly to allow my users to attach mods, mutators, skins/models, ect. for Unreal Tournament. This also frees my users who write these types of modifications to post their work on the forum. Plus, I got the space and bandwidth to do it.

I consider AttachMOD an excellent feature that's essential to our board.

Thanks Acyd Burn for making such an excellent MOD.

My Forum
Post Reply