phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

replacing corner images with invisible ones

All style (template, theme and imageset) related questions for the new release; advice, feedback here please.

replacing corner images with invisible ones

Postby Dragosvr92 » Sun Apr 15, 2012 1:58 am

The corners_right/left.png images have white corners instead of invisible ones.
This makes it a bit annoying when you want to change your background colour to something else, like a black colour, as you may see the white corners.
Change the Background colour here to a black one and you will see what im talking about...
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: replacing corner images with invisible ones

Postby Arty » Sun Apr 15, 2012 8:03 am

Those corner images no longer exist in 3.1
Formerly known as CyberAlien.
User avatar
Arty
Styles Team
Styles Team
 
Posts: 796
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars

Re: replacing corner images with invisible ones

Postby Dragosvr92 » Sun Apr 15, 2012 1:28 pm

Arty wrote:Those corner images no longer exist in 3.1

Because it uses border-radius, i guess, right?
Maybe we should fix the issue in 3.0
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: replacing corner images with invisible ones

Postby callumacrae » Sun Apr 15, 2012 2:28 pm

TheKiller wrote:
Arty wrote:Those corner images no longer exist in 3.1

Because it uses border-radius, i guess, right?
Maybe we should fix the issue in 3.0

There's not point in fixing it in 3.0 if it has been fixed in 3.1 already.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: replacing corner images with invisible ones

Postby Dragosvr92 » Mon Apr 16, 2012 2:22 am

If theres a security issue in 3.0, you wont bother fixing it, as it will be fixed in 3.1 ?
The last 3.0 released version should deal with most issues accoured at the time it was released.
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: replacing corner images with invisible ones

Postby DavidIQ » Mon Apr 16, 2012 2:43 am

Security issues are different. This is obviously not a security issue. :roll:
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 759
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: replacing corner images with invisible ones

Postby Dragosvr92 » Mon Apr 16, 2012 3:06 am

Yes, i do know, but the idea is the same.
The last version should be as clean as it can be, right?
Is there a reason on wwhy this shouldnt be done, or wasnt done for all this years?
Its not like IE6 is still supported and you prefered not to bother, as they will look the same.. there were other browsers that supported invisible images.
Theres a IE hack to make them invisible there also, which could have benn included with phpbb.
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: replacing corner images with invisible ones

Postby DavidIQ » Mon Apr 16, 2012 3:12 am

Well if you want to fix it yourself and send a pull request then by all means do that. Otherwise our resources are better spent working on 3.1 ;-)
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 759
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: replacing corner images with invisible ones

Postby Dragosvr92 » Mon Apr 16, 2012 5:43 pm

It doesnt take more than lets say 10 minutes to do so, especially for designers that know to use their photo-editor well.
I can try to modify them if they ill be used, and i wont bother making them for nothing.
More experienced people could do it fast and better than me tho....
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: replacing corner images with invisible ones

Postby Dragosvr92 » Tue Apr 17, 2012 6:59 am

After i posted here i re-checked them and noticed that they are indeed invisible, but they need the white thing, as thats whats round...
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Next

Return to [3.0/Olympus] Styling

Who is online

Users browsing this forum: No registered users and 5 guests